9front - general discussion about 9front
 help / color / mirror / Atom feed
From: ori@eigenstate.org
To: 9front@9front.org
Subject: Re: [9front] [PATCH 3/6] nusb/ptp: add mention to nusb man page and fix implementation per spec to start with transaction id 1, not 0.
Date: Fri, 12 Jan 2024 10:16:50 -0500	[thread overview]
Message-ID: <29B9949F335D74FC85BAA0A483E809AD@eigenstate.org> (raw)
In-Reply-To: <2235407F64A748720719B820A36567D0@smtp.pobox.com>

Quoth unobe@cpan.org:
> 
> So this patch looks good as well?  I don't have a commit bit.

No. It doesn't seem to do what you said it does.

I thought the goal was to start from transaction id 1,
but your change makes it start from id 0.


  parent reply	other threads:[~2024-01-12 15:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-28  6:26 Romano
2023-09-28  7:01 ` unobe
2023-12-11 19:19   ` [9front] [PATCH 3/6] nusb/ptp: add mention to nusb man page and fix implementation per spec to start with transaction id 0, not 1 unobe
2023-12-11 20:22 ` [9front] [PATCH 3/6] nusb/ptp: add mention to nusb man page and fix implementation per spec to start with transaction id 1, not 0 ori
2023-12-11 22:55   ` unobe
2023-12-11 20:36 ` ori
2024-01-12  4:14   ` unobe
2024-01-12  8:05     ` igor
2024-01-12 15:16     ` ori [this message]
2024-01-12 17:22       ` [9front] [PATCH 3/6] nusb/ptp: add mention to nusb man page and fix implementation per spec to start with transaction id 0, not 1 unobe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29B9949F335D74FC85BAA0A483E809AD@eigenstate.org \
    --to=ori@eigenstate.org \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).