9front - general discussion about 9front
 help / color / mirror / Atom feed
From: igor@9lab.org
To: 9front@9front.org
Cc: igor@9lab.org
Subject: Re: [9front] [PATCH 3/6] nusb/ptp: add mention to nusb man page and fix implementation per spec to start with transaction id 1, not 0.
Date: Fri, 12 Jan 2024 09:05:31 +0100	[thread overview]
Message-ID: <563595A91E31522427D47639E157CA7B@9lab.org> (raw)
In-Reply-To: <2235407F64A748720719B820A36567D0@smtp.pobox.com>

> So this patch looks good as well?  […]

Thanks!

Just tested it and can now browse iPhone photos on 9front ☺

After applying the fix and plugging in an iPhone, photos are
accessible via '/shr':

  term% ls '/shr/sdU96cb0/Internal Storage/DCIM'
  […]
  '/shr/sdU96cb0/Internal Storage/DCIM/202312__'
  '/shr/sdU96cb0/Internal Storage/DCIM/202401__'

Unless there are any more objections or someone beats me to it I will
merge it this weekend.

Cheers,
Igor

Quoth unobe@cpan.org:
> So this patch looks good as well?  I don't have a commit bit.
> 
> Quoth ori@eigenstate.org:
> > Wait, I retract that.
> > 
> > Quoth Romano <unobe@cpan.org>:
> > > 
> > > Apple iPhones can now be used to transfer images. There is still an issue with the iPhone permission, wherein an actor has to be pretty quick on the trigger to Allow the connection from the iPhone side, but that would require a pause somewhere in the handshake that I did not have time to look into further. This patch at least allows the connection to succeed when permitted.
> > >  	sessionId = getpid();
> > > +	transId   = 0;
> > >  	if(ptprpc(nil, OpenSession, 1, sessionId) < 0)
> > 
> > Setting transid=0 here means that when we
> > enter vptprpc, we do:
> > 
> > 	t = transId++;
> > 	...
> > 	PUT4(rpc.transid, t);
> > 
> > which will put *0* into the transaction ID.
> > Am I missing something here?
> > 
> 


  reply	other threads:[~2024-01-12  8:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-28  6:26 Romano
2023-09-28  7:01 ` unobe
2023-12-11 19:19   ` [9front] [PATCH 3/6] nusb/ptp: add mention to nusb man page and fix implementation per spec to start with transaction id 0, not 1 unobe
2023-12-11 20:22 ` [9front] [PATCH 3/6] nusb/ptp: add mention to nusb man page and fix implementation per spec to start with transaction id 1, not 0 ori
2023-12-11 22:55   ` unobe
2023-12-11 20:36 ` ori
2024-01-12  4:14   ` unobe
2024-01-12  8:05     ` igor [this message]
2024-01-12 15:16     ` ori
2024-01-12 17:22       ` [9front] [PATCH 3/6] nusb/ptp: add mention to nusb man page and fix implementation per spec to start with transaction id 0, not 1 unobe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563595A91E31522427D47639E157CA7B@9lab.org \
    --to=igor@9lab.org \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).