9front - general discussion about 9front
 help / color / mirror / Atom feed
From: cinap_lenrek@felloff.net
To: 9front@9front.org
Subject: Re: [9front] cmd/rc: fix leaking runq->cmdfile (patch)
Date: Tue, 09 Nov 2021 20:27:30 +0100	[thread overview]
Message-ID: <316DC1762EF8EB5DC3E1756D964999CD@felloff.net> (raw)
In-Reply-To: <2203D6ED28C225EDCF76C0393E1960A8@9lab.org>

nice, looks good to me on first glance.

note, we should probably add a setmalloctag(p, getcallerpc(&n));
inside emallc() to make your leak hunt easier.

--
cinap

  reply	other threads:[~2021-11-09 19:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09 12:45 igor
2021-11-09 19:27 ` cinap_lenrek [this message]
2021-11-10 13:21   ` igor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=316DC1762EF8EB5DC3E1756D964999CD@felloff.net \
    --to=cinap_lenrek@felloff.net \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).