9front - general discussion about 9front
 help / color / mirror / Atom feed
* Re: [9front] vt selection patch
@ 2018-09-03 16:55 cinap_lenrek
  0 siblings, 0 replies; 3+ messages in thread
From: cinap_lenrek @ 2018-09-03 16:55 UTC (permalink / raw)
  To: 9front

haha! good work.

observations:
- the line selection is a bit strange (starting point x coordinate can be moved by end point)
- might want to clear current selection when switching between linesel/blocksel

regardless of these nits, i'm fine with commiting this. thank you!

--
cinap


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [9front] vt selection patch
@ 2018-09-03 18:06 cinap_lenrek
  0 siblings, 0 replies; 3+ messages in thread
From: cinap_lenrek @ 2018-09-03 18:06 UTC (permalink / raw)
  To: 9front

pushed, with small amendments.

--
cinap


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [9front] vt selection patch
@ 2018-09-03 17:02 cinap_lenrek
  0 siblings, 0 replies; 3+ messages in thread
From: cinap_lenrek @ 2018-09-03 17:02 UTC (permalink / raw)
  To: 9front

another nit:

it ignores the linewrap, so if a line got wrapped by vt, it inserts a 
\n that should be not there. (see the > at the right)

--
cinap


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-09-03 18:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-03 16:55 [9front] vt selection patch cinap_lenrek
2018-09-03 17:02 cinap_lenrek
2018-09-03 18:06 cinap_lenrek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).