bug: awk crash (patch included)

bug: awk crash (patch included)

[Pete]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

Here is a patch for an awk crash.  The crash can be reproduced by doing
this:

    % awk 'BEGIN{nextfile}'

This is an illegal awk program, but instead of printing the error
message, it tries to Bterm(nil) and doesn't get as far as the error
message.  The patch fixes that and awk spits out the error instead of 
crashing.

(Sorry for the cross-post, someone on the grid told me the main ML was a
better place to send this than 9front-bugs.)

[-- Attachment #2: awk.patch --]
[-- Type: text/plain, Size: 310 bytes --]

diff -r b1bd262dc055 sys/src/cmd/awk/lib.c
--- a/sys/src/cmd/awk/lib.c	Mon Apr 15 19:48:03 2019 +0000
+++ b/sys/src/cmd/awk/lib.c	Mon Apr 15 15:52:22 2019 -0700
@@ -167,7 +167,7 @@
 
 void nextfile(void)
 {
-	if (infile != &stdin)
+	if (infile && infile != &stdin)
 		Bterm(infile);
 	infile = nil;
 	argno++;

Re: [9front] bug: awk crash (patch included)

[Nick Owens]

i believe this was fixed in commit e4a7fe526ec5. see
https://code.9front.org/hg/plan9front/rev/e4a7fe526ec5 for a web copy.

On Wed, Apr 24, 2019 at 9:43 PM Pete <pete@debu.gs> wrote:
>
> Here is a patch for an awk crash.  The crash can be reproduced by doing
> this:
>
>     % awk 'BEGIN{nextfile}'
>
> This is an illegal awk program, but instead of printing the error
> message, it tries to Bterm(nil) and doesn't get as far as the error
> message.  The patch fixes that and awk spits out the error instead of
> crashing.
>
> (Sorry for the cross-post, someone on the grid told me the main ML was a
> better place to send this than 9front-bugs.)

Re: [9front] bug: awk crash (patch included)

[Pete]

On 2019年04月25日 09:46, Nick Owens wrote:
> i believe this was fixed in commit e4a7fe526ec5. see
> https://code.9front.org/hg/plan9front/rev/e4a7fe526ec5 for a web copy.

Ah, indeed.  Sorry for the crosspost and also the noise, then.