From: Jacob Moody <moody@mail.posixcafe.org>
To: 9front@9front.org
Subject: [9front] [PATCH] make exportfs give "standard" error for file does exist
Date: Sun, 23 Jul 2023 16:07:03 -0500 [thread overview]
Message-ID: <71ed8c49-2174-0ec5-ad59-5e1c5256fc70@posixcafe.org> (raw)
Certain 9p clients *cough* Guhnew/Linucks *cough* expect a fileserver to give back specifically "file does not exist"
for this certain error case. For linux specifically this results in create being broken. This patch catches this error
and returns back what the broken client would like.
This sucks, telling linux to go kick rocks would also be fine in my opinion.
diff 801664db7f4ed740d40f40f93f1aa4dd48e1c329 uncommitted
--- a//sys/src/cmd/exportfs/exportsrv.c
+++ b//sys/src/cmd/exportfs/exportsrv.c
@@ -198,7 +198,10 @@
wf = file(f->f, t->work.wname[i]);
if(wf == nil){
errstr(err, sizeof err);
- e = err;
+ if(strstr(err, "does not exist") != nil)
+ e = "file does not exist";
+ else
+ e = err;
break;
}
Accept:
next reply other threads:[~2023-07-23 21:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 21:07 Jacob Moody [this message]
2023-07-23 22:03 ` Stuart Morrow
2023-07-23 22:11 ` Jacob Moody
2023-07-23 22:24 ` Stuart Morrow
2023-07-24 0:19 ` Jacob Moody
2023-07-24 21:20 ` Stuart Morrow
2023-07-24 22:33 ` Jacob Moody
2023-07-24 0:07 ` Michael Forney
2023-07-24 0:56 ` Jacob Moody
2023-07-24 2:12 ` ori
2023-07-24 8:13 ` hiro
2023-07-24 23:37 ` Jacob Moody
2023-07-24 23:54 ` ori
2023-07-24 0:51 ` [9front] " Anthony Martin
2023-07-24 1:03 ` Jacob Moody
2023-07-24 4:13 ` Anthony Martin
2023-07-24 4:20 ` ori
2023-07-25 6:09 ` Anthony Martin
2023-07-25 8:26 ` hiro
2023-07-25 13:14 ` ori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71ed8c49-2174-0ec5-ad59-5e1c5256fc70@posixcafe.org \
--to=moody@mail.posixcafe.org \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).