From: Anthony Martin <ality@pbrane.org>
To: 9front@9front.org
Subject: [9front] Re: [PATCH] make exportfs give "standard" error for file does exist
Date: Sun, 23 Jul 2023 17:51:25 -0700 [thread overview]
Message-ID: <ZL3LDWtYUAr-OBzb@alice> (raw)
In-Reply-To: <71ed8c49-2174-0ec5-ad59-5e1c5256fc70@posixcafe.org>
The lady doth protest too much, methinks.
Here's a list of all file servers that do not use Enonexist,
aka "file does not exist" for this purpose:
git/fs
nusb/disk
nusb/serial
nusb/usbd
skelfs
There's a commonality here. These are 9front snowflakes.
Just make them use the common error.
There is one wrinkle to my theory, however. When the kernel
attempts to walk a path but only partially succeeds (i.e. when
devwalk, mntwalk, or shrwalk returns with wq->clone set to
nil), it makes up an error since it has no way of knowing the
real underlying cause of failure. The error walk chooses is
"does not exist" or Enotdir even though it could be completely
wrong. That error could be renamed. I propose
extern char Ecrippled[]; /* cannot walk */
but not really.
Alternatively, you could send a patch for net/9p/error.c to
lkml. Have you seen that monstrosity? What's one more
addition?
Cheers,
Anthony
next prev parent reply other threads:[~2023-07-24 0:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 21:07 [9front] " Jacob Moody
2023-07-23 22:03 ` Stuart Morrow
2023-07-23 22:11 ` Jacob Moody
2023-07-23 22:24 ` Stuart Morrow
2023-07-24 0:19 ` Jacob Moody
2023-07-24 21:20 ` Stuart Morrow
2023-07-24 22:33 ` Jacob Moody
2023-07-24 0:07 ` Michael Forney
2023-07-24 0:56 ` Jacob Moody
2023-07-24 2:12 ` ori
2023-07-24 8:13 ` hiro
2023-07-24 23:37 ` Jacob Moody
2023-07-24 23:54 ` ori
2023-07-24 0:51 ` Anthony Martin [this message]
2023-07-24 1:03 ` [9front] " Jacob Moody
2023-07-24 4:13 ` Anthony Martin
2023-07-24 4:20 ` ori
2023-07-25 6:09 ` Anthony Martin
2023-07-25 8:26 ` hiro
2023-07-25 13:14 ` ori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL3LDWtYUAr-OBzb@alice \
--to=ality@pbrane.org \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).