From: ori@eigenstate.org
To: 9front@9front.org
Subject: Re: [9front] [PATCH] diff: retain original file names
Date: Sun, 22 May 2022 19:24:05 -0400 [thread overview]
Message-ID: <833445198A71E1A330A18CFA1427A21A@eigenstate.org> (raw)
In-Reply-To: <399c430d-65da-0c60-e046-38c19f7c6305@posixcafe.org>
Quoth Jacob Moody <moody@mail.posixcafe.org>:
> On 5/22/22 10:41, Ori Bernstein wrote:
> >
> > When diffing non-regular files, like /dev/null,
> > pipes, and similar, diff will generate a temp
> > file to diff against. This is the right thing
> > to do, but the temp file leaks into the diff.
> >
> > This patch retains the original file name all
> > the way through to diff output.
>
> This has been a pet peeve of mine, glad to see
> I wasn't the only one. Looks good to me! One
> small comment inline that I could take or leave.
>
pushed, fixed comment in separate commit.
thanks!
prev parent reply other threads:[~2022-05-22 23:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 16:41 Ori Bernstein
2022-05-22 18:45 ` Jacob Moody
2022-05-22 23:24 ` ori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=833445198A71E1A330A18CFA1427A21A@eigenstate.org \
--to=ori@eigenstate.org \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).