* Re: [9front] [PATCH] netsurf: webfs POST implementation
@ 2020-03-22 2:11 kokamoto
0 siblings, 0 replies; 4+ messages in thread
From: kokamoto @ 2020-03-22 2:11 UTC (permalink / raw)
To: 9front
Thank you very much Philippe!
> Also, the webfs clients exhaustion issue should now be fixed.
Yes, now I have no error of '/mnt/web/clone no more clients'.
Kenji
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [9front] [PATCH] netsurf: webfs POST implementation
2020-03-22 21:37 ` Kyle Nusbaum
@ 2020-03-22 22:14 ` telephil9
0 siblings, 0 replies; 4+ messages in thread
From: telephil9 @ 2020-03-22 22:14 UTC (permalink / raw)
To: knusbaum, 9front, telephil9
Tests did not show any issue so far but broader testing could help here, so I'm all for pushing when there is no obvious contraindication (at this stage of the project obviously).
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [9front] [PATCH] netsurf: webfs POST implementation
2020-03-22 19:25 ` [9front] " Kyle Nusbaum
@ 2020-03-22 21:37 ` Kyle Nusbaum
2020-03-22 22:14 ` telephil9
0 siblings, 1 reply; 4+ messages in thread
From: Kyle Nusbaum @ 2020-03-22 21:37 UTC (permalink / raw)
To: 9front, telephil9
That said, we *know* we're getting these handle exhaustion errors. I think we can merge this now, and if we start seeing header errors, we can fix that then.
On March 22, 2020 2:25:57 PM CDT, Kyle Nusbaum <knusbaum@sdf.org> wrote:
>Thanks a bunch!
>
>The only hesitation I have is with the closing of the body when data is
>finished. This frees the webfs handle, but if netsurf tries to read any
>headers after, it will encounter errors. Maybe it is not doing that,
>but I don't see any reason why it couldn't do that.
>
>
>On March 21, 2020 2:17:04 PM CDT, telephil9@gmail.com wrote:
>>Hi,
>>
>>Here is a patch to implement POST requests in netsurf webfs fetcher.
>>I could not test multipart POST requests yet as I could not find a
>site
>>that uses this encoding method.
>>Also, the webfs clients exhaustion issue should now be fixed.
>>
>>Regards,
>>Philippe
>
>-- Kyle
-- Kyle
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [9front] [PATCH] netsurf: webfs POST implementation
2020-03-21 19:17 telephil9
@ 2020-03-22 19:25 ` Kyle Nusbaum
2020-03-22 21:37 ` Kyle Nusbaum
0 siblings, 1 reply; 4+ messages in thread
From: Kyle Nusbaum @ 2020-03-22 19:25 UTC (permalink / raw)
To: 9front, telephil9
Thanks a bunch!
The only hesitation I have is with the closing of the body when data is finished. This frees the webfs handle, but if netsurf tries to read any headers after, it will encounter errors. Maybe it is not doing that, but I don't see any reason why it couldn't do that.
On March 21, 2020 2:17:04 PM CDT, telephil9@gmail.com wrote:
>Hi,
>
>Here is a patch to implement POST requests in netsurf webfs fetcher.
>I could not test multipart POST requests yet as I could not find a site
>that uses this encoding method.
>Also, the webfs clients exhaustion issue should now be fixed.
>
>Regards,
>Philippe
-- Kyle
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-22 22:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-22 2:11 [9front] [PATCH] netsurf: webfs POST implementation kokamoto
-- strict thread matches above, loose matches on Subject: below --
2020-03-21 19:17 telephil9
2020-03-22 19:25 ` [9front] " Kyle Nusbaum
2020-03-22 21:37 ` Kyle Nusbaum
2020-03-22 22:14 ` telephil9
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).