9front - general discussion about 9front
 help / color / mirror / Atom feed
From: Romano <unobe@cpan.org>
To: 9front@9front.org
Subject: Re: arm64 fails to link when float converted to int
Date: Tue, 4 Aug 2020 00:58:27 -0700	[thread overview]
Message-ID: <AA3B6994BCCA0BA8F573545FF7A57885@smtp.pobox.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

Cinap,

I saw your recent merges to address problems with the initial patch.  How could I have helped more to test in some other way rather than just building netsurf and the system I'm on? Perhaps write other little C programs that test out corner cases for type conversion? Is that how you notice it causing other problems?

[-- Attachment #2: Type: message/rfc822, Size: 9417 bytes --]

From: Romano <unobe@cpan.org>
To: 9front@9front.org
Subject: Re: arm64 fails to link when float converted to int (Was Re: [9front] netsurf native frontend (text_insert: illegal combination FCVTZSDW FCON NONE REG))
Date: Sat, 1 Aug 2020 11:41:55 -0700
Message-ID: <4805B3AEFECCAC9B0E43ACC47F838B40@smtp.pobox.com>

> this is clearly a compiler bug.
> 
> lets compare with the other compilers:
> ...

Thank you very much for the guided walk-through, and providing a patch to fix! It's been two decades since I looked at assembler before this past week or so, and therefore your notes were helpful in giving me an overview of what was happening (the -S flag is handy). I still need to take some more time in order to really understand the architectural differences (e.g., the intel 'haha' moment), but some other projects are most likely going to take priority if I don't run into any other compiler bugs.

> we'll need to to do a bunch of test now to make sure this
> change doesnt break anything.
> 
> feel free to test and report any errors would be appreciated.

On my rpi4, I re-made 7c with the patch and installed it, then did 'cd /sys/src; mk clean; mk': no error occurred. I also reverted the modification I had made for netsurf native, mk clean'd, and it built without modification too.

Should I be kicking the tires in some other way?

                 reply	other threads:[~2020-08-04  7:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AA3B6994BCCA0BA8F573545FF7A57885@smtp.pobox.com \
    --to=unobe@cpan.org \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).