[9front] reform hjfs file creation broken in current release and after

[9front] reform hjfs file creation broken in current release and after

[Stanley Lieber]

tested on reform, no other arm64 machines at hand.

9331 release works fine.

9442 and after, hjfs cannot create a file, throws error:

can't create: file: 'file' phase error -- create

background:

9442 and 9446 iso images both exhibited this problem, so i tried 9331, which was fine. did sysupdate, copied rebuilt kernel to dos, rebooted, and now get the same error when trying to create files anywhere on the system.

editing existing files seems to work fine, only new creates fail.

sl

Re: [9front] reform hjfs file creation broken in current release and after

[Sigrid Solveig Haflínudóttir]

Sounds like a bug in 7c.

Re: [9front] reform hjfs file creation broken in current release and after

[sl]

i accidentally typed some wrong commit numbers.  i regret the error.
here are the correct facts:

9442 release works fine.

9931 and after, hjfs cannot create a file, throws error:

can't create: file: 'file' phase error -- create

sl

Re: [9front] reform hjfs file creation broken in current release and after

[Sigrid Solveig Haflínudóttir]

I tried hjfs built with 7c with the last change to it (the C compiler) reverted and it seems to work fine. *With* it, hjfs can't properly initialize the filesystem - it's empty, not even /adm/users is there. I think that would explain the error. I will ping cinap as soon as he's on IRC.

[9front] Re: [9front] reform hjfs file creation broken in current release and after

[Stanley Lieber]

On July 4, 2023 3:46:13 PM EDT, "Sigrid Solveig Haflínudóttir" <sigrid@ftrv.se> wrote:
>I tried hjfs built with 7c with the last change to it (the C compiler) reverted and it seems to work fine. *With* it, hjfs can't properly initialize the filesystem - it's empty, not even /adm/users is there. I think that would explain the error. I will ping cinap as soon as he's on IRC.
>

thanks. i was also able to get a working hjfs:

cd /sys/src/cmd/7c
git/revert -c 4fd09def0fc51d0606e677f1ab59ad695d1cd780 `{pwd}

sl

[9front] Re: [9front] reform hjfs file creation broken in current release and after

[Stanley Lieber]

On July 4, 2023 3:46:13 PM EDT, "Sigrid Solveig Haflínudóttir" <sigrid@ftrv.se> wrote:
>I tried hjfs built with 7c with the last change to it (the C compiler) reverted and it seems to work fine. *With* it, hjfs can't properly initialize the filesystem - it's empty, not even /adm/users is there. I think that would explain the error. I will ping cinap as soon as he's on IRC.
>

this might have been easily overlooked if everybody was working with fully installed systems on cwfs. i started with the stock reform live image (hjfs) from the current release, and it booted fine, but no new files could be created.

next: after rebuilding the kernel with current sources, ether0=type=iwl in plan9.ini seems to have no effect. firmware iwn-6005 is located, loaded, and recognized with no errors, but ether0 is still the built-in ethernet. i'll try again once i have the whole system fully updated.

sl

Re: [9front] Re: [9front] reform hjfs file creation broken in current release and after

[cinap_lenrek]

> I tried hjfs built with 7c with the last change to it (the C compiler)
> reverted and it seems to work fine. *With* it, hjfs can't properly
> initialize the filesystem - it's empty, not even /adm/users is there.
> I think that would explain the error. I will ping cinap as soon as he's on IRC.

i'll take a look. thanks.

> next: after rebuilding the kernel with current sources, ether0=type=iwl
> in plan9.ini seems to have no effect. firmware iwn-6005 is located, loaded,
> and recognized with no errors, but ether0 is still the built-in ethernet.
> i'll try again once i have the whole system fully updated.

yeah, the arm kernels do not implement isaconfig() at all. so it will have
no effect there.

--
cinap

Re: [9front] Re: [9front] reform hjfs file creation broken in current release and after

[sl]

>> next: after rebuilding the kernel with current sources, ether0=type=iwl
>> in plan9.ini seems to have no effect. firmware iwn-6005 is located, loaded,
>> and recognized with no errors, but ether0 is still the built-in ethernet.
>> i'll try again once i have the whole system fully updated.
> 
> yeah, the arm kernels do not implement isaconfig() at all. so it will have
> no effect there.

ah, ok. i got it on the network:

bind -a '#l1' /net
echo 'key proto=wpapsk essid=XXX !password=YYY' >>/mnt/factotum/ctl
aux/wpa -2 -s XXX -p /net/ether1
ip/ipconfig ether /net/ether1

sl

Re: [9front] Re: [9front] reform hjfs file creation broken in current release and after

[cinap_lenrek]

ok, found it and pushed a fix to 7c.

The problem was the line

uvlong i;
int j;

i = j = -1;

generating:

MOVW $-1, R1			<- !!!!
/* SXTW R1, R1			<- missing */
MOVW R1, j+xxx(SP)
MOV R1, i+xxx(SP)

the SXTW was missing because of an optimisation,
eliding these SXTW's as MOVW generally sign
extends already so the SXTW instruction is
not needed...

but there is an exception!

MOVW with a *CONSTANT* is actually equivalent to
MOVWU and always zero extends! (because you
could'v just used MOV instead if you wanted 64-bit?)

fixed the optimiser handling this special case.

--
cinap

Re: [9front] Re: [9front] reform hjfs file creation broken in current release and after

[sl]

> ok, found it and pushed a fix to 7c.

thanks!

sl

Re: [9front] Re: [9front] reform hjfs file creation broken in current release and after

[cinap_lenrek]

given that hjfs is broken for arm64 in the current release,
we should probably do a service pack releae.

i just took the latest nighly builds for pi3 and reform
images and made new torrents.

https://felloff.net/usr/cinap_lenrek/9front/9front-9948.pi3.img.gz
https://felloff.net/usr/cinap_lenrek/9front/9front-9948.pi3.img.gz.torrent
https://felloff.net/usr/cinap_lenrek/9front/9front-9948.reform.img.gz
https://felloff.net/usr/cinap_lenrek/9front/9front-9948.reform.img.gz.torrent

cpu% sha1sum -2 256 9front-9948*.gz
52cb6b0c453432802da14f9e4ea45d894b956d64eab4486b00516d6e351e22d9	9front-9948.pi3.img.gz
a11243fe5dd217e9ecbd6c98768dd0b860a44693c14d4946ae2ddf56fabbc969	9front-9948.reform.img.gz

the relevant change fixing the hjfs issue is this one:

1ce4662c613bd407ef91ed8a782d7ed25bbc9d9b 7c: dont replace SXTW instruction following MOVW $const, r

other changes since the initial release are:

2810cc5d0c01b06e678b50995edb724c739b8eed git/walk: fix usage on new repo
67970c4c6bdaed7fb0b6e6a22f77f23a7acd2f0a git(1): remove lies from manual, improve wording.
f7a16b5e2cc38aed7985b0144bb2655d14ea6f5a git(1): update and clean up git/walk section
6076b4f9367729f60efe5a729070caaa5e38d29f git/revert: only look at changed files
9f77ec48bf63083912cbcb5ef50e5561ebb3c578 git/diff: always respect the specified branch
44af27c55cdd14118676e96415206b3b348f69d5 git/walk: add -b option to override base branch
2ea66b170147f66e05cd82da83b795cf4d660e26 bcm64, imx8: writing CAPR_EL1 (to turn fpu on/off) needs a intruction barrier
47d3af71a33e242099a6a6130dcbe7ab4de9a895 /lib/troll: We have created something new that we named R9, an OS strongly inspired by Plan 9, written in the Rust programming language.
b4c916efce5e1476d9ac7079ca8ffec54fdcbce2 /lib/theo: You are trying to compare a pig and a moon rocket.
14fe59e83905a5d84bbf257807976f25c0421c65 games/opl3: fix choking on high tempo streams
1d63115328e8ca2fe06159da5f18bde43adca3df upas/imap4d: fix bad censorship of the password when debug is enabled.
c9a6a759bebccaccf3662b3fddad4821bd74f26b upas/imap4d: return SEARCH response in caps.
ae1cfc9082b3f56a8502938b892bf0555110a741 zuke(1): document audio/readtags
c138c7d8813dcd77cfe33e37f1416427819b5e93 readtags, zuke: extract cover images stored in the audio files (thanks g-w1)
b868b9919f570cbcbdb3c713bf1431b9d843ea43 ndb/dns: hack for the caching server for delegated nameservers

could you update the website and replace the link to the
9front-9931.pi3.* and 9front-9931.reform.* with the new ones?

--
cinap

Re: [9front] Re: [9front] reform hjfs file creation broken in current release and after

[cinap_lenrek]

forgot the most important thing for the service pack release...

the MUSIC:

https://archive.org/download/benny-hill-song/Benny%20Hill%20Song.mp3

--
cinap

[9front] Re: [9front] Re: [9front] reform hjfs file creation broken in current release and after

[Stanley Lieber]

On July 5, 2023 6:57:17 AM EDT, cinap_lenrek@felloff.net wrote:
>given that hjfs is broken for arm64 in the current release,
>we should probably do a service pack releae.
>
>i just took the latest nighly builds for pi3 and reform
>images and made new torrents.
>
>https://felloff.net/usr/cinap_lenrek/9front/9front-9948.pi3.img.gz
>https://felloff.net/usr/cinap_lenrek/9front/9front-9948.pi3.img.gz.torrent
>https://felloff.net/usr/cinap_lenrek/9front/9front-9948.reform.img.gz
>https://felloff.net/usr/cinap_lenrek/9front/9front-9948.reform.img.gz.torrent
>
>cpu% sha1sum -2 256 9front-9948*.gz
>52cb6b0c453432802da14f9e4ea45d894b956d64eab4486b00516d6e351e22d9	9front-9948.pi3.img.gz
>a11243fe5dd217e9ecbd6c98768dd0b860a44693c14d4946ae2ddf56fabbc969	9front-9948.reform.img.gz
>
>the relevant change fixing the hjfs issue is this one:
>
>1ce4662c613bd407ef91ed8a782d7ed25bbc9d9b 7c: dont replace SXTW instruction following MOVW $const, r
>
>other changes since the initial release are:
>
>2810cc5d0c01b06e678b50995edb724c739b8eed git/walk: fix usage on new repo
>67970c4c6bdaed7fb0b6e6a22f77f23a7acd2f0a git(1): remove lies from manual, improve wording.
>f7a16b5e2cc38aed7985b0144bb2655d14ea6f5a git(1): update and clean up git/walk section
>6076b4f9367729f60efe5a729070caaa5e38d29f git/revert: only look at changed files
>9f77ec48bf63083912cbcb5ef50e5561ebb3c578 git/diff: always respect the specified branch
>44af27c55cdd14118676e96415206b3b348f69d5 git/walk: add -b option to override base branch
>2ea66b170147f66e05cd82da83b795cf4d660e26 bcm64, imx8: writing CAPR_EL1 (to turn fpu on/off) needs a intruction barrier
>47d3af71a33e242099a6a6130dcbe7ab4de9a895 /lib/troll: We have created something new that we named R9, an OS strongly inspired by Plan 9, written in the Rust programming language.
>b4c916efce5e1476d9ac7079ca8ffec54fdcbce2 /lib/theo: You are trying to compare a pig and a moon rocket.
>14fe59e83905a5d84bbf257807976f25c0421c65 games/opl3: fix choking on high tempo streams
>1d63115328e8ca2fe06159da5f18bde43adca3df upas/imap4d: fix bad censorship of the password when debug is enabled.
>c9a6a759bebccaccf3662b3fddad4821bd74f26b upas/imap4d: return SEARCH response in caps.
>ae1cfc9082b3f56a8502938b892bf0555110a741 zuke(1): document audio/readtags
>c138c7d8813dcd77cfe33e37f1416427819b5e93 readtags, zuke: extract cover images stored in the audio files (thanks g-w1)
>b868b9919f570cbcbdb3c713bf1431b9d843ea43 ndb/dns: hack for the caching server for delegated nameservers
>
>could you update the website and replace the link to the
>9front-9931.pi3.* and 9front-9931.reform.* with the new ones?
>
>--
>cinap
>

i'll get this done tonight.

thanks again,

sl

Re: [9front] Re: [9front] Re: [9front] reform hjfs file creation broken in current release and after

[cinap_lenrek]

no, thank YOU! :)

--
cinap