From: ori@eigenstate.org
To: 9front@9front.org
Subject: Re: [9front] Patch for 9pfid(2) manpage
Date: Mon, 17 May 2021 09:17:26 -0700 [thread overview]
Message-ID: <BB8BF564F2C6E3770851061E7FEF56E9@eigenstate.org> (raw)
In-Reply-To: <3455FE019696B419862F82A1B9DDC013@gmail.com>
Quoth kjn@9project.net:
> I think we should mention the pointer to the Srv in 9pfid(2). This
> reference is useful, for example, when one needs to call srvrelease()
> and srvacquire() while handling requests. I didn't discover the
> pointer was available through the Req struct until I looked through
> the headers.
>
> diff -r 99d7d683afa4 sys/man/2/9pfid
> --- a/sys/man/2/9pfid Tue Apr 27 16:08:06 2021 +0200
> +++ b/sys/man/2/9pfid Mon May 17 10:50:11 2021 -0500
> @@ -51,6 +51,7 @@
> Fid *fid;
> Fid *afid;
> Fid *newfid;
> + Srv *srv;
> \fI...\fP
> } Req;
> .fi
>
Applied.
The only reason to leave it undocumented would
be to leave us open to change the API, but I
don't see a reason to -- and it's not in the
implementation specific bit of the struct.
prev parent reply other threads:[~2021-05-18 13:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 15:56 kjn
2021-05-17 16:17 ` ori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BB8BF564F2C6E3770851061E7FEF56E9@eigenstate.org \
--to=ori@eigenstate.org \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).