Re: [9front] strndup should use strnlen and memcpy

["José Miguel Sánchez García" <soy.jmi2k@gmail.com>]

I'd also use strnlen. My current understanding is: strnlen is used to
impose a limit on a bigger str, without caring about its end if it is
bigger than size chars. strncmp compares strings up to a limit,
without caring about their ends if they are bigger than size chars.
The "n" limitation disregards the terminator, so here we shouldn't
make exception. Also, using strnlen makes strndup unaware of the
problem, relying on the correct behavior of strnlen. The only drawback
would be efficiency, but let's be honest: that branch will be
predicted pretty easily by modern CPU.

Just my 2 cents, take all of this with a grain of salt.


On Fri, Dec 18, 2020 at 1:00 PM Eli Cohen <echoline@gmail.com> wrote:
>
> I know what we should do but have no idea on a personal level
>
> On Fri, Dec 18, 2020 at 3:53 AM Kemal <kemalinanc8@gmail.com> wrote:
> >
> > At this point I have no idea what we should do now.