From: Eli Cohen <echoline@gmail.com>
To: 9front@9front.org
Subject: Re: [9front] strndup should use strnlen and memcpy
Date: Fri, 18 Dec 2020 03:02:12 -0800 [thread overview]
Message-ID: <CAHwi9bwwU3Q4gM80w=576U-NE0GT=-xYeR+qJakYNg0TNnDrnA@mail.gmail.com> (raw)
In-Reply-To: <CABO6shcx46Vah7FnXHK639nGrc07Cfm+7-S_vBE0RwGwOH4M8g@mail.gmail.com>
I am very surprised either way :o
it should definitely be strnlen... strn* are specifically for cases
where you want to specify a length, specifically where the strings are
not necessarily null-terminated
this is probably all my fault, I apologize for horsing around. it does
seem like I saw the cover of a DVD of that movie wargames once but I'm
sure there's more to it...?
On Fri, Dec 18, 2020 at 2:50 AM Kemal <kemalinanc8@gmail.com> wrote:
>
> 2020-12-18 13:31 GMT+03:00, Sigrid Solveig Haflínudóttir <ftrvxmtrx@gmail.com>:
> >> Open Group does not specify if arg1 should be null terminated or not.
> >> https://pubs.opengroup.org/onlinepubs/9699919799/functions/strdup.html
> >
> > "Applications should not assume that strndup() will allocate ( size + 1)
> > bytes when strlen(s) is smaller than size."
> >
> > Pretty sure this means it's supposed to be null-terminated, or
> > otherwise it wouldn't mention the "dangerous" strlen right there.
> >
> >
> I don't know, I also think that str is \0 terminated but that seems a
> bit unclear.
next prev parent reply other threads:[~2020-12-18 11:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 8:22 Xiao-Yong Jin
2020-12-18 8:38 ` Sigrid Solveig Haflínudóttir
2020-12-18 9:01 ` tlaronde
2020-12-18 9:59 ` Sigrid Solveig Haflínudóttir
2020-12-18 10:21 ` Kemal
2020-12-18 10:31 ` Sigrid Solveig Haflínudóttir
2020-12-18 10:48 ` Kemal
2020-12-18 11:02 ` Eli Cohen [this message]
2020-12-18 11:05 ` Eli Cohen
2020-12-18 11:29 ` tlaronde
2020-12-18 11:37 ` Sigrid Solveig Haflínudóttir
2020-12-18 11:43 ` Eli Cohen
2020-12-18 11:50 ` Kemal
2020-12-18 11:55 ` Eli Cohen
2020-12-18 12:06 ` Kemal
2020-12-18 13:22 ` José Miguel Sánchez García
2020-12-18 14:34 ` Devon H. O'Dell
2020-12-18 14:26 ` Devon H. O'Dell
2020-12-18 15:27 ` ori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHwi9bwwU3Q4gM80w=576U-NE0GT=-xYeR+qJakYNg0TNnDrnA@mail.gmail.com' \
--to=echoline@gmail.com \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).