From: Lucas Francesco <lucas.francesco93@gmail.com>
To: 9front@9front.org
Subject: [9front] zlib update
Date: Wed, 27 May 2020 19:06:15 -0300 [thread overview]
Message-ID: <CAF=5iUVsKSgWseEChs-X-7JenBU7URYgYi3AvKh+znM_XH6vQw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]
Today people asked me to resubmit the zlib patches that I had sent
months ago due to netsurf/nsfb. I actually had things working and
clean on my system since back then, but I was confused between a
decision of sending the build "half-broken" but with the final result
working, or triggering a flag up that I didn't know if it should or
not, after looking up, it seems the cleaner route is just to do the
latter.
the newer zlib uses lseek/open/write, functions specified in
<unistd.h>, but it actually doesn't include the header when building
some of the .$O, what happened it was just that our linker would spot
the functions even after the compiler warning due to the lax
prototypeless functions in ANSI C std and build it fine. (the -B flag
on 2c would do it)
the option I'm going here is just to make it include <unistd.h>, that
requires anything that uses ape/zlib to define _POSIX_SOURCE, all
tests I've done points out it is working fine, page works, the zlib
tests passes and netsurf png decoding work as always with it.
[-- Attachment #2: zlibprefinal.patch --]
[-- Type: application/octet-stream, Size: 698454 bytes --]
next reply other threads:[~2020-05-27 22:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 22:06 Lucas Francesco [this message]
2020-05-27 22:43 ` ori
2020-06-09 2:06 ` Lucas Francesco
2020-06-09 3:10 ` ori
2020-06-09 3:12 ` ori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF=5iUVsKSgWseEChs-X-7JenBU7URYgYi3AvKh+znM_XH6vQw@mail.gmail.com' \
--to=lucas.francesco93@gmail.com \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).