rio exit menu

rio exit menu

[qwx]

Hello,

Currently, rio hides an 'Exit' entry in mouse menu 3 unless argv[0] contains
the string ".out".

The inlined patch below removes the check and exposes the entry.

While potentially dangerous, it is more convenient than manually killing a
given rio, and several people including me have been using this or similar
patches for a while.

What do you think?  Would anyone else like to see this merged?

Thanks,

qwx


diff -r 49bd5e4c9bde sys/src/cmd/rio/rio.c
--- a/sys/src/cmd/rio/rio.c	Wed Feb 07 18:53:08 2018 +0000
+++ b/sys/src/cmd/rio/rio.c	Thu Feb 15 23:00:00 2018 +0100
@@ -125,10 +125,6 @@
 	Image *i;
 	Rectangle r;
 
-	if(strstr(argv[0], ".out") == nil){
-		menu3str[Exit] = nil;
-		Hidden--;
-	}
 	initstr = nil;
 	kbdin = nil;
 	maxtab = 0;

Re: [9front] rio exit menu

[Julius Schmidt]

I'm opposed to this change.
I would kill too many rios by accident :)

On Sun, 9 Dec 2018, qwx wrote:

> Hello,
>
> Currently, rio hides an 'Exit' entry in mouse menu 3 unless argv[0] contains
> the string ".out".
>
> The inlined patch below removes the check and exposes the entry.
>
> While potentially dangerous, it is more convenient than manually killing a
> given rio, and several people including me have been using this or similar
> patches for a while.
>
> What do you think?  Would anyone else like to see this merged?
>
> Thanks,
>
> qwx
>
>
> diff -r 49bd5e4c9bde sys/src/cmd/rio/rio.c
> --- a/sys/src/cmd/rio/rio.c	Wed Feb 07 18:53:08 2018 +0000
> +++ b/sys/src/cmd/rio/rio.c	Thu Feb 15 23:00:00 2018 +0100
> @@ -125,10 +125,6 @@
> 	Image *i;
> 	Rectangle r;
>
> -	if(strstr(argv[0], ".out") == nil){
> -		menu3str[Exit] = nil;
> -		Hidden--;
> -	}
> 	initstr = nil;
> 	kbdin = nil;
> 	maxtab = 0;
>

Re: [9front] rio exit menu

[Steve Simon]

I agree with aiju, don't do it.

-Steve

Re: [9front] rio exit menu

[Stanley Lieber]

I agree with Julius.

Serious question: When and why do you need to kill rio cleanly?

sl

Re: [9front] rio exit menu

[hiro]

when you want to reuse the window.

Re: [9front] rio exit menu

[qwx]

Fair enough.  Calling off the paratroops.

Fwiw, I use subrios a lot, and it comes handy.

Thanks!

qwx

Re: [9front] rio exit menu

[Ethan Gardener]

On Sun, Dec 9, 2018, at 9:03 PM, hiro wrote:
> when you want to reuse the window.

I used it to close the window, being tidier and sometimes more accessible than selecting Delete in the parent.  Come to think of it, I didn't close subrios very often.  It only got used when I was shutting down to get the window out of the way so I didn't think its contents (extra editors) still needed to be closed properly.

I'm starting to think that old patch of mine shouldn't have worked when it did, calling emouse from a program which doesn't normally include event.h.  Yay for blundering into functionality.  I remember doing that & then fixing it at a later date, but can't remember how (or how well) I fixed it.

Re: [9front] rio exit menu

[Ethan Gardener]

More complete patch, only because it turned up as a preliminary to what I intended to do.  I can't post it on my contrib now although I do think that's the best place for such patches.  I'm too stressed to look up how.

diff -c /sys/src/cmd/rio/rio.c rio_exit_conf/rio.c
/sys/src/cmd/rio/rio.c:52,57 - rio_exit_conf/rio.c:52,58
  	Delete,
  	Hide,
  	Exit,
+ 	Hidden,
  };
  
  enum
/sys/src/cmd/rio/rio.c:81,88 - rio_exit_conf/rio.c:82,87
  	menu2str
  };
  
- int	Hidden = Exit+1;
- 
  char		*menu3str[100] = {
   [New]		"New",
   [Reshape]	"Resize",
/sys/src/cmd/rio/rio.c:124,133 - rio_exit_conf/rio.c:123,128
  	Image *i;
  	Rectangle r;
  
- 	if(strstr(argv[0], ".out") == nil){
- 		menu3str[Exit] = nil;
- 		Hidden--;
- 	}
  	initstr = nil;
  	kbdin = nil;
  	maxtab = 0;
/sys/src/cmd/rio/rio.c:730,740 - rio_exit_conf/rio.c:725,732
  		hide();
  		break;
  	case Exit:
- 		if(Hidden > Exit){
- 			send(exitchan, nil);
- 			break;
- 		}
- 		/* else fall through */
+ 		send(exitchan, nil);
+ 		break;
  	default:
  		unhide(i);
  		break;