9front - general discussion about 9front
 help / color / mirror / Atom feed
From: ori@eigenstate.org
To: 9front@9front.org
Subject: Re: [9front] git lca bug
Date: Sat, 05 Mar 2022 22:44:24 -0500	[thread overview]
Message-ID: <DFB090A5862CEA80EBC96B14BD54368D@eigenstate.org> (raw)
In-Reply-To: <6223bab7.1c69fb81.6fc89.a14b@mx.google.com>

Quoth Michael Forney <mforney@mforney.org>:
> However, I don't understand that commit message. The definition of
> LCA(b, g) that I've read is "the lowest node that has both b and g
> as descendents". In the graph

How do you define 'lowest' in this case?  especially
without walking the whole graph from the initial
commit, which is very slow in large repos?

It was initially being done by 'smallest number of
steps from the starting points', but that's not
correct, because in the graph above, the shortest sum
of steps goes via 'h' to 'a'.

> It returns M rather than I.

That's definitely not intended.

> Any idea on how best to fix this?

Not yet. Tweaking repainting to sum the weight when
colors meet seems like it may fix it, but I haven't
thought it through yet.

  reply	other threads:[~2022-03-06  3:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-05 19:32 Michael Forney
2022-03-06  3:44 ` ori [this message]
2022-03-06  5:21   ` Michael Forney
2022-03-06 18:33     ` ori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DFB090A5862CEA80EBC96B14BD54368D@eigenstate.org \
    --to=ori@eigenstate.org \
    --cc=9front@9front.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).