Subject: Re: [9front] [PATCH] tee: remove unused variable in
Date: Tue, 15 Nov 2022 22:09:06 -0500 [thread overview]
Message-ID: <F52BAA9C1E8DBEEEA758286456EF2D5F@eigenstate.org> (raw)
Quoth Michael Forney <email@example.com>:
> Sigrid Solveig Haflínudóttir <firstname.lastname@example.org> wrote:
> > Your original patch looks wrong - git/import could
> > not apply it. Git/export is supposed to produce the
> > right thing.
> Although the patch isn't what you'd get with git/commit and git/export,
> I don't think anything is wrong with it apart from being a bit
> unconventional. We should be able to deal with it with our tools.
> There are two issues here:
> 1. The patch relies on standard filename detection behavior that
> our new patch implementation doesn't follow. There are plenty
> of patches in the wild like this, and I mentioned it in the
> `patch(1) filename detection thread` a while back. I have a local
> patch patch in my queue that fixes this.
> 2. git/import has no way to forward -p arguments to patch. git am
> has this, and it seems both useful and easy to add to git/import.
> With both of those fixed, git/import -p0 would do the trick.
seems sane to me.
next prev parent reply other threads:[~2022-11-16 3:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 13:46 mkf9
2022-11-15 22:07 ` mkf9
2022-11-16 1:47 ` Sigrid Solveig Haflínudóttir
2022-11-16 2:57 ` Michael Forney
2022-11-16 3:01 ` Sigrid Solveig Haflínudóttir
2022-11-16 3:09 ` ori [this message]
2022-11-16 10:34 ` mkf9
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).