9front - general discussion about 9front
 help / color / mirror / Atom feed
From: cinap_lenrek@felloff.net
To: 9front@9front.org
Subject: Re: [9front] sysproc: raise limit on shebang lines, handle quoting.
Date: Sun, 10 Jul 2022 20:29:44 +0200	[thread overview]
Message-ID: <FA4664774E39346AC2EC9A9EBE02AD91@felloff.net> (raw)
In-Reply-To: <80149CA0DE680A311CCA7F4AE4F4167B@eigenstate.org>

> -	s += 2;
> -	n -= 2;		/* skip #! */

i'd keep these lines, avoiding the multiple s+2 expressions
down the road.

my main concern is making sure we'r not blowing the stack
with this change on archs with small 4k stacks like 32bit arm.

just need to checks...


> +			ehdr = (void*)buf;

not sure if that will yield properly aligned ehdr pointer as
buf is just char[]. i think that was the reason it was a union

otherwise looks ok.


  reply	other threads:[~2022-07-10 18:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-10 15:38 ori
2022-07-10 18:29 ` cinap_lenrek [this message]
2022-07-16 17:20   ` ori
2022-07-16 17:29     ` ori
2022-07-16 17:45       ` ori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FA4664774E39346AC2EC9A9EBE02AD91@felloff.net \
    --to=cinap_lenrek@felloff.net \
    --cc=9front@9front.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).