issues on modifying code in ext/cfg.ml in CIL

issues on modifying code in ext/cfg.ml in CIL

[haihao shen]

[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]

Hi all,

Currently I am doing some work on CIL. I would like to obtain the
conditional result (true/false) in the DOT file generated by CIL. Therefore,
I modified the code in ext/cfg.ml.

let d_cfgedge (src) () (dest) =
    match src.skind with
      | If (_, tb, fb, _) ->
   (if (List.mem dest tb.bstmts) then
      dprintf "%a -> %a [label=\"true\"]"
             d_cfgnodename src
             d_cfgnodename dest
    else if (List.mem dest fb.bstmts) then
      dprintf "%a -> %a [label=\"false\"]"
             d_cfgnodename src
             d_cfgnodename dest
    else
      dprintf "%a -> %a [label=\"true$\"]"(*true likely, note that no false
likely!!!*)
             d_cfgnodename src
             d_cfgnodename dest);
      | _ -> dprintf "%a -> %a"
        d_cfgnodename src
        d_cfgnodename dest

However, I am wondering whether my solution is correct becuase there is no
related document explaining this issue. In particularly, in my real cases, I
found the highlighted case is also hit. I am also wondering whether there
are other cases that I don't consider here.

Look forward to your reply. Any concern or feedback would be greatly
appreciated.

Thanks,
Haihao

[-- Attachment #2: Type: text/html, Size: 1560 bytes --]

Re: [Caml-list] issues on modifying code in ext/cfg.ml in CIL

[Gabriel Kerneis]

On Wed, Jul 21, 2010 at 10:59:25AM +0800, haihao shen wrote:
> Currently I am doing some work on CIL.

There is a dedicated CIL mailing-list:
cil-users@lists.sourceforge.net

You should get more feedback there.

Regards,
-- 
Gabriel

Re: [Caml-list] issues on modifying code in ext/cfg.ml in CIL

[haihao shen]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

Thanks.

On Wed, Jul 21, 2010 at 2:36 PM, Gabriel Kerneis <kerneis@pps.jussieu.fr>wrote:

> On Wed, Jul 21, 2010 at 10:59:25AM +0800, haihao shen wrote:
> > Currently I am doing some work on CIL.
>
> There is a dedicated CIL mailing-list:
> cil-users@lists.sourceforge.net
>
> You should get more feedback there.
>
> Regards,
> --
> Gabriel
>

[-- Attachment #2: Type: text/html, Size: 716 bytes --]