From: "Nicolás Ojeda Bär" <nicolas.ojeda.bar@lexifi.com>
To: monnier.florent@gmail.com
Cc: OCaml Mailing List <caml-list@inria.fr>
Subject: Re: [Caml-list] Unix.truncate for Windows
Date: Wed, 25 Jul 2018 12:35:48 +0200 [thread overview]
Message-ID: <CADK7aFOS8KXJ5_RUg3hwMM7ASu=O4bzPBxOTgFR-dX7XFqRSMw@mail.gmail.com> (raw)
In-Reply-To: <CAE1DttAyvZ-4zJdhDiV2pdvXvEn2NvTAeDjWsymKcFV1rMcUcw@mail.gmail.com>
Dear Florent,
Yes, it would be a nice to fill out the Windows implementation of Unix.truncate!
Best would be if you could open a PR to the official OCaml repository at
https://github.com/ocaml/ocaml
General guidelines about the procedure are available at:
https://github.com/ocaml/ocaml/blob/trunk/CONTRIBUTING.md
If you need any help with the mechanics of this or modifying the
compiler source code, I will be happy to lend you a hand, just let me
know.
Best wishes,
Nicolás
On Wed, Jul 25, 2018 at 11:59 AM Florent Monnier
<monnier.florent@gmail.com> wrote:
>
> Hi,
>
> I wrote some stub code for the function Unix.truncate for Windows:
>
> https://github.com/fccm/ocaml_unix_truncate_win32
>
> I mainly found the code from Rosettacode:
> https://rosettacode.org/wiki/Truncate_a_file#Windows
>
> Now I would like to know if the upstream would be interested to get
> this code included?
> If yes, what's next? should I try to make the change to ocaml's git (I
> would need some help then) or some upstream developer will do the job?
>
> Regards
> Florent Monnier
>
> --
> Caml-list mailing list. Subscription management and archives:
> https://sympa.inria.fr/sympa/arc/caml-list
> Beginner's list: http://groups.yahoo.com/group/ocaml_beginners
> Bug reports: http://caml.inria.fr/bin/caml-bugs
--
Caml-list mailing list. Subscription management and archives:
https://sympa.inria.fr/sympa/arc/caml-list
Beginner's list: http://groups.yahoo.com/group/ocaml_beginners
Bug reports: http://caml.inria.fr/bin/caml-bugs
prev parent reply other threads:[~2018-07-25 10:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 9:59 Florent Monnier
2018-07-25 10:35 ` Nicolás Ojeda Bär [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADK7aFOS8KXJ5_RUg3hwMM7ASu=O4bzPBxOTgFR-dX7XFqRSMw@mail.gmail.com' \
--to=nicolas.ojeda.bar@lexifi.com \
--cc=caml-list@inria.fr \
--cc=monnier.florent@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).