From: cdrice at pobox.com (Charles Dee Rice)
Subject: [PATCH v2] Remove trailing slash after remove-suffix
Date: Sat, 13 Dec 2014 19:28:23 +0000 (UTC) [thread overview]
Message-ID: <1089416287.277235.1418498903540.JavaMail.yahoo@jws10633.mail.bf1.yahoo.com> (raw)
In-Reply-To: <1418470251-7909-1-git-send-email-cgit@cryptocrack.de>
Thank you so much for the quick reply!
> The previous version had a flaw (bogus pointer if there is no ".git"
> suffix). This one is much more readable add should be applied on top of
> the Git 2.2.0 patch (which adds strip_suffix() and strip_suffix_mem()).
Version 1 would definitely cause some issues. My brief testing confirmed it could cut off the last letter of the repot name for a bare repo -- "blah.git" became "bla". It did work for non-bare repos, though -- "blah/.git" became "blah" and worked! ;)
Applying the latest version of Christian's git 2.2.0 patch from November + your version 2 looks like it works perfectly!
I now see both bare and non-bare repos working with scanning and remove-suffix enabled. All repo features (refs, log, tree, etc) work correctly in each case.
This really had me scratching my head -- I'm glad to see I wasn't doing something silly after all! Thanks again!
- Chuck
next prev parent reply other threads:[~2014-12-13 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-13 8:41 Should remove-suffix=1 and scan-path work with non-bare repos? cdrice
2014-12-13 10:59 ` cgit
2014-12-13 11:01 ` [PATCH] Remove trailing slash after remove-suffix cgit
2014-12-13 11:30 ` [PATCH v2] " cgit
2014-12-13 19:28 ` cdrice [this message]
2014-12-24 1:55 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1089416287.277235.1418498903540.JavaMail.yahoo@jws10633.mail.bf1.yahoo.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).