From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: Should remove-suffix=1 and scan-path work with non-bare repos?
Date: Sat, 13 Dec 2014 11:59:06 +0100 [thread overview]
Message-ID: <20141213105906.5716.95194@typhoon.lan> (raw)
In-Reply-To: <53640519.166708.1418460094104.JavaMail.yahoo@jws10604.mail.bf1.yahoo.com>
On Sat, 13 Dec 2014 at 09:41:34, Charles Dee Rice wrote:
> [...]
> and a non-bare repot /tmp/testing/blah/.git, I see unexpected behavior for the "blah" repot. The repot is named "blah/" on the cgit index page (note trailing slash). The Summary page for "blah/" works as expected, but attempting to view any other data (refs, log, tree, etc), I receive a "No repositories found" error.
> [...]
> Should scanning + remove-suffix work with non-bare repots? Please forgive me if I have missed something simple -- I've been scratching my head on this for a while. Am I doing something silly or missing something in the documentation?
> [...]
While the trailing slash is technically correct, it does not look nice
and does not match what we do in cgit_repobasename() -- so I consider
this a bug. Could be please try the patch I am going to send in a
second?
Regards,
Lukas
next prev parent reply other threads:[~2014-12-13 10:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-13 8:41 cdrice
2014-12-13 10:59 ` cgit [this message]
2014-12-13 11:01 ` [PATCH] Remove trailing slash after remove-suffix cgit
2014-12-13 11:30 ` [PATCH v2] " cgit
2014-12-13 19:28 ` cdrice
2014-12-24 1:55 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141213105906.5716.95194@typhoon.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).