List for cgit developers and users
 help / color / mirror / Atom feed
From: zwinkau at kit.edu (zwinkau at kit.edu)
Subject: [PATCH 3/8] Skip forbidden characters.
Date: Tue,  1 Jul 2014 09:40:28 +0200	[thread overview]
Message-ID: <1404200433-30081-3-git-send-email-zwinkau@kit.edu> (raw)
In-Reply-To: <1404200433-30081-1-git-send-email-zwinkau@kit.edu>

From: Sebastian Buchwald <Sebastian.Buchwald at kit.edu>

---
 html.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/html.c b/html.c
index 91047ad..6037eec 100644
--- a/html.c
+++ b/html.c
@@ -129,7 +129,8 @@ void html_txt(const char *txt)
 	const char *t = txt;
 	while (t && *t) {
 		int c = *t;
-		if (c == '<' || c == '>' || c == '&') {
+		if ((c < 0x20 && c != '\t' && c != '\n' && c != '\r')
+				|| (c == '<' || c == '>' || c == '&')) {
 			html_raw(txt, t - txt);
 			if (c == '>')
 				html("&gt;");
@@ -150,7 +151,8 @@ void html_ntxt(int len, const char *txt)
 	const char *t = txt;
 	while (t && *t && len--) {
 		int c = *t;
-		if (c == '<' || c == '>' || c == '&') {
+		if ((c < 0x20 && c != '\t' && c != '\n' && c != '\r')
+				|| (c == '<' || c == '>' || c == '&')) {
 			html_raw(txt, t - txt);
 			if (c == '>')
 				html("&gt;");
@@ -186,7 +188,8 @@ void html_attr(const char *txt)
 	const char *t = txt;
 	while (t && *t) {
 		int c = *t;
-		if (c == '<' || c == '>' || c == '\'' || c == '\"' || c == '&') {
+		if (c == '<' || c == '>' || c == '\'' || c == '\"' || c == '&'
+				|| (c < 0x20 && c != '\t' && c != '\n' && c != '\r')) {
 			html_raw(txt, t - txt);
 			if (c == '>')
 				html("&gt;");
-- 
1.9.1



  parent reply	other threads:[~2014-07-01  7:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01  7:40 [PATCH 1/8] Can add diffs to Atom feed entries zwinkau
2014-07-01  7:40 ` [PATCH 2/8] Improved readability zwinkau
2014-07-01  7:40 ` zwinkau [this message]
2014-07-01 20:29   ` [PATCH 3/8] Skip forbidden characters john
2014-07-02 11:57     ` qznc
2014-07-01  7:40 ` [PATCH 4/8] add xml-header to atom-feed zwinkau
2014-07-01  7:40 ` [PATCH 5/8] display updated, use urn/url for atom:id zwinkau
2014-07-01  7:40 ` [PATCH 6/8] only one content tag allowed, so remove the text one zwinkau
2014-07-01  7:40 ` [PATCH 7/8] add <link rel='self'> to atom feed zwinkau
2014-07-01  7:40 ` [PATCH 8/8] fix html error in diff output for binary files zwinkau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404200433-30081-3-git-send-email-zwinkau@kit.edu \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).