From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 3/8] Skip forbidden characters.
Date: Tue, 1 Jul 2014 21:29:03 +0100 [thread overview]
Message-ID: <20140701202903.GC13153@serenity.lan> (raw)
In-Reply-To: <1404200433-30081-3-git-send-email-zwinkau@kit.edu>
On Tue, Jul 01, 2014 at 09:40:28AM +0200, zwinkau at kit.edu wrote:
> From: Sebastian Buchwald <Sebastian.Buchwald at kit.edu>
Why do we want to do this? Does it not break anything that uses
whitespace="pre" (explicitly or implicitly)?
> ---
> html.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/html.c b/html.c
> index 91047ad..6037eec 100644
> --- a/html.c
> +++ b/html.c
> @@ -129,7 +129,8 @@ void html_txt(const char *txt)
> const char *t = txt;
> while (t && *t) {
> int c = *t;
> - if (c == '<' || c == '>' || c == '&') {
> + if ((c < 0x20 && c != '\t' && c != '\n' && c != '\r')
> + || (c == '<' || c == '>' || c == '&')) {
> html_raw(txt, t - txt);
> if (c == '>')
> html(">");
> @@ -150,7 +151,8 @@ void html_ntxt(int len, const char *txt)
> const char *t = txt;
> while (t && *t && len--) {
> int c = *t;
> - if (c == '<' || c == '>' || c == '&') {
> + if ((c < 0x20 && c != '\t' && c != '\n' && c != '\r')
> + || (c == '<' || c == '>' || c == '&')) {
> html_raw(txt, t - txt);
> if (c == '>')
> html(">");
> @@ -186,7 +188,8 @@ void html_attr(const char *txt)
> const char *t = txt;
> while (t && *t) {
> int c = *t;
> - if (c == '<' || c == '>' || c == '\'' || c == '\"' || c == '&') {
> + if (c == '<' || c == '>' || c == '\'' || c == '\"' || c == '&'
> + || (c < 0x20 && c != '\t' && c != '\n' && c != '\r')) {
> html_raw(txt, t - txt);
> if (c == '>')
> html(">");
next prev parent reply other threads:[~2014-07-01 20:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 7:40 [PATCH 1/8] Can add diffs to Atom feed entries zwinkau
2014-07-01 7:40 ` [PATCH 2/8] Improved readability zwinkau
2014-07-01 7:40 ` [PATCH 3/8] Skip forbidden characters zwinkau
2014-07-01 20:29 ` john [this message]
2014-07-02 11:57 ` qznc
2014-07-01 7:40 ` [PATCH 4/8] add xml-header to atom-feed zwinkau
2014-07-01 7:40 ` [PATCH 5/8] display updated, use urn/url for atom:id zwinkau
2014-07-01 7:40 ` [PATCH 6/8] only one content tag allowed, so remove the text one zwinkau
2014-07-01 7:40 ` [PATCH 7/8] add <link rel='self'> to atom feed zwinkau
2014-07-01 7:40 ` [PATCH 8/8] fix html error in diff output for binary files zwinkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701202903.GC13153@serenity.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).