List for cgit developers and users
 help / color / mirror / Atom feed
From: list at eworm.de (Christian Hesse)
Subject: [PATCH 3/4] ui-plain: fix resource leak: free before return
Date: Fri,  9 Oct 2015 14:55:49 +0200	[thread overview]
Message-ID: <1444395350-18204-3-git-send-email-list@eworm.de> (raw)
In-Reply-To: <1444395350-18204-1-git-send-email-list@eworm.de>

From: Christian Hesse <mail at eworm.de>

Coverity-id: 13940
Signed-off-by: Christian Hesse <mail at eworm.de>
---
 ui-plain.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui-plain.c b/ui-plain.c
index 0dd1a8b..4c73607 100644
--- a/ui-plain.c
+++ b/ui-plain.c
@@ -51,6 +51,7 @@ static int print_object(const unsigned char *sha1, const char *path)
 	cgit_print_http_headers();
 	html_raw(buf, size);
 	free(mimetype);
+	free(buf);
 	return 1;
 }
 
-- 
2.6.1



  parent reply	other threads:[~2015-10-09 12:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-09 12:55 [PATCH 1/4] ui-repolist: " list
2015-10-09 12:55 ` [PATCH 2/4] ui-repolist: fix resource leak: free allocation from cgit_currenturl list
2015-10-09 12:55 ` list [this message]
2015-10-09 13:50   ` [PATCH 3/4] ui-plain: fix resource leak: free before return Jason
2015-10-09 12:55 ` [PATCH 4/4] ui-plain: fix resource leak: free before assigning NULL list
2015-10-09 13:49 ` [PATCH 1/4] ui-repolist: fix resource leak: free before return Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444395350-18204-3-git-send-email-list@eworm.de \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).