From: list at eworm.de (Christian Hesse)
Subject: [PATCH 1/4] ui-repolist: fix resource leak: free before return
Date: Fri, 9 Oct 2015 14:55:47 +0200 [thread overview]
Message-ID: <1444395350-18204-1-git-send-email-list@eworm.de> (raw)
From: Christian Hesse <mail at eworm.de>
Coverity-id: 13931
Signed-off-by: Christian Hesse <mail at eworm.de>
---
ui-repolist.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ui-repolist.c b/ui-repolist.c
index ac1b3e3..4f52e0f 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -18,8 +18,10 @@ static time_t read_agefile(char *path)
char *buf;
struct strbuf date_buf = STRBUF_INIT;
- if (readfile(path, &buf, &size))
+ if (readfile(path, &buf, &size)) {
+ free(buf);
return -1;
+ }
if (parse_date(buf, &date_buf) == 0)
result = strtoul(date_buf.buf, NULL, 10);
--
2.6.1
next reply other threads:[~2015-10-09 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 12:55 list [this message]
2015-10-09 12:55 ` [PATCH 2/4] ui-repolist: fix resource leak: free allocation from cgit_currenturl list
2015-10-09 12:55 ` [PATCH 3/4] ui-plain: fix resource leak: free before return list
2015-10-09 13:50 ` Jason
2015-10-09 12:55 ` [PATCH 4/4] ui-plain: fix resource leak: free before assigning NULL list
2015-10-09 13:49 ` [PATCH 1/4] ui-repolist: fix resource leak: free before return Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444395350-18204-1-git-send-email-list@eworm.de \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).