* [PATCH 1/4] ui-repolist: fix resource leak: free before return
@ 2015-10-09 12:55 list
2015-10-09 12:55 ` [PATCH 2/4] ui-repolist: fix resource leak: free allocation from cgit_currenturl list
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: list @ 2015-10-09 12:55 UTC (permalink / raw)
From: Christian Hesse <mail at eworm.de>
Coverity-id: 13931
Signed-off-by: Christian Hesse <mail at eworm.de>
---
ui-repolist.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ui-repolist.c b/ui-repolist.c
index ac1b3e3..4f52e0f 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -18,8 +18,10 @@ static time_t read_agefile(char *path)
char *buf;
struct strbuf date_buf = STRBUF_INIT;
- if (readfile(path, &buf, &size))
+ if (readfile(path, &buf, &size)) {
+ free(buf);
return -1;
+ }
if (parse_date(buf, &date_buf) == 0)
result = strtoul(date_buf.buf, NULL, 10);
--
2.6.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/4] ui-repolist: fix resource leak: free allocation from cgit_currenturl
2015-10-09 12:55 [PATCH 1/4] ui-repolist: fix resource leak: free before return list
@ 2015-10-09 12:55 ` list
2015-10-09 12:55 ` [PATCH 3/4] ui-plain: fix resource leak: free before return list
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: list @ 2015-10-09 12:55 UTC (permalink / raw)
From: Christian Hesse <mail at eworm.de>
Coverity-id: 13930
Signed-off-by: Christian Hesse <mail at eworm.de>
---
ui-repolist.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ui-repolist.c b/ui-repolist.c
index 4f52e0f..a2e9e07 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -108,14 +108,16 @@ static int is_in_url(struct cgit_repo *repo)
static void print_sort_header(const char *title, const char *sort)
{
+ char *currenturl = cgit_currenturl();
html("<th class='left'><a href='");
- html_attr(cgit_currenturl());
+ html_attr(currenturl);
htmlf("?s=%s", sort);
if (ctx.qry.search) {
html("&q=");
html_url_arg(ctx.qry.search);
}
htmlf("'>%s</a></th>", title);
+ free(currenturl);
}
static void print_header(void)
--
2.6.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 3/4] ui-plain: fix resource leak: free before return
2015-10-09 12:55 [PATCH 1/4] ui-repolist: fix resource leak: free before return list
2015-10-09 12:55 ` [PATCH 2/4] ui-repolist: fix resource leak: free allocation from cgit_currenturl list
@ 2015-10-09 12:55 ` list
2015-10-09 13:50 ` Jason
2015-10-09 12:55 ` [PATCH 4/4] ui-plain: fix resource leak: free before assigning NULL list
2015-10-09 13:49 ` [PATCH 1/4] ui-repolist: fix resource leak: free before return Jason
3 siblings, 1 reply; 6+ messages in thread
From: list @ 2015-10-09 12:55 UTC (permalink / raw)
From: Christian Hesse <mail at eworm.de>
Coverity-id: 13940
Signed-off-by: Christian Hesse <mail at eworm.de>
---
ui-plain.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui-plain.c b/ui-plain.c
index 0dd1a8b..4c73607 100644
--- a/ui-plain.c
+++ b/ui-plain.c
@@ -51,6 +51,7 @@ static int print_object(const unsigned char *sha1, const char *path)
cgit_print_http_headers();
html_raw(buf, size);
free(mimetype);
+ free(buf);
return 1;
}
--
2.6.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 4/4] ui-plain: fix resource leak: free before assigning NULL
2015-10-09 12:55 [PATCH 1/4] ui-repolist: fix resource leak: free before return list
2015-10-09 12:55 ` [PATCH 2/4] ui-repolist: fix resource leak: free allocation from cgit_currenturl list
2015-10-09 12:55 ` [PATCH 3/4] ui-plain: fix resource leak: free before return list
@ 2015-10-09 12:55 ` list
2015-10-09 13:49 ` [PATCH 1/4] ui-repolist: fix resource leak: free before return Jason
3 siblings, 0 replies; 6+ messages in thread
From: list @ 2015-10-09 12:55 UTC (permalink / raw)
From: Christian Hesse <mail at eworm.de>
Coverity-id: 13939
Signed-off-by: Christian Hesse <mail at eworm.de>
---
ui-plain.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ui-plain.c b/ui-plain.c
index 4c73607..e4beb99 100644
--- a/ui-plain.c
+++ b/ui-plain.c
@@ -84,8 +84,10 @@ static void print_dir(const unsigned char *sha1, const char *base,
slash = strrchr(fullpath, '/');
if (slash)
*(slash + 1) = 0;
- else
+ else {
+ free(fullpath);
fullpath = NULL;
+ }
html("<li>");
cgit_plain_link("../", NULL, NULL, ctx.qry.head, ctx.qry.sha1,
fullpath);
--
2.6.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/4] ui-repolist: fix resource leak: free before return
2015-10-09 12:55 [PATCH 1/4] ui-repolist: fix resource leak: free before return list
` (2 preceding siblings ...)
2015-10-09 12:55 ` [PATCH 4/4] ui-plain: fix resource leak: free before assigning NULL list
@ 2015-10-09 13:49 ` Jason
3 siblings, 0 replies; 6+ messages in thread
From: Jason @ 2015-10-09 13:49 UTC (permalink / raw)
Merged.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-09 13:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-09 12:55 [PATCH 1/4] ui-repolist: fix resource leak: free before return list
2015-10-09 12:55 ` [PATCH 2/4] ui-repolist: fix resource leak: free allocation from cgit_currenturl list
2015-10-09 12:55 ` [PATCH 3/4] ui-plain: fix resource leak: free before return list
2015-10-09 13:50 ` Jason
2015-10-09 12:55 ` [PATCH 4/4] ui-plain: fix resource leak: free before assigning NULL list
2015-10-09 13:49 ` [PATCH 1/4] ui-repolist: fix resource leak: free before return Jason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).