List for cgit developers and users
 help / color / mirror / Atom feed
From: lukasz at jany.st (Lukasz Janyst)
Subject: Render markdown files in tree view
Date: Thu, 08 Dec 2016 23:53:23 +0100	[thread overview]
Message-ID: <1481237603.1507596.813167825.319B6E17@webmail.messagingengine.com> (raw)
In-Reply-To: <20161208201821.GA30275@john.keeping.me.uk>

On Thu, Dec 8, 2016, at 21:18, John Keeping wrote:
> On Thu, Dec 08, 2016 at 04:06:01PM +0100, Lukasz Janyst wrote:
> In relation to the first patch specifically, I posted a more
> comprehensive series a couple of months ago following a request on the
> list, the thread starts here:
> 
> 	https://lists.zx2c4.com/pipermail/cgit/2016-September/003289.html
> 
> Does that series work for your use case?  I think your patch will break
> rendering for genuine source code and that remains a key use case for
> CGit.

I checked the default syntax-highlighting.py and it still works fine
with my patches because it inserts all the tags it needs. The ones that
I removed were redundant. I did not check the other highlighter.

I have skimmed through your patches. I think it would work for my use
case. I especially like the idea of applying filters to binary blobs.
However, it seems to be pretty complicated. I can handle most of the use
cases I can think of with regular source filters provided that the two
patches to the C code are applied and I would be able to handle all of
them if I could apply source filters to binary blobs.

   Lukasz


  reply	other threads:[~2016-12-08 22:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-08 15:06 lukasz
2016-12-08 20:18 ` john
2016-12-08 22:53   ` lukasz [this message]
2016-12-14 13:39 andy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481237603.1507596.813167825.319B6E17@webmail.messagingengine.com \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).