List for cgit developers and users
 help / color / mirror / Atom feed
* [PATCH 1/1] email-gravatar: fix html syntax issues
@ 2014-01-15 12:39 mail
  2014-01-15 13:43 ` Jason
  0 siblings, 1 reply; 3+ messages in thread
From: mail @ 2014-01-15 12:39 UTC (permalink / raw)


an attribute value specification must be an attribute value literal
unless SHORTTAG YES is specified
---
 filters/email-gravatar.lua | 2 +-
 filters/email-gravatar.py  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/filters/email-gravatar.lua b/filters/email-gravatar.lua
index 3aad258..52cf426 100644
--- a/filters/email-gravatar.lua
+++ b/filters/email-gravatar.lua
@@ -15,7 +15,7 @@ function filter_open(email, page)
 end
 
 function filter_close()
-	html("<img src='//www.gravatar.com/avatar/" .. md5 .. "?s=13&amp;d=retro' width=13 height=13 alt='Gravatar' /> " .. buffer)
+	html("<img src='//www.gravatar.com/avatar/" .. md5 .. "?s=13&amp;d=retro' width='13' height='13' alt='Gravatar' /> " .. buffer)
 	return 0
 end
 
diff --git a/filters/email-gravatar.py b/filters/email-gravatar.py
index 88bc776..d70440e 100755
--- a/filters/email-gravatar.py
+++ b/filters/email-gravatar.py
@@ -36,4 +36,4 @@ sys.stdout = codecs.getwriter("utf-8")(sys.stdout.detach())
 md5 = hashlib.md5(email.encode()).hexdigest()
 text = sys.stdin.read().strip()
 
-print("<img src='//www.gravatar.com/avatar/" + md5 + "?s=13&amp;d=retro' width=13 height=13 alt='Gravatar' /> " + text)
+print("<img src='//www.gravatar.com/avatar/" + md5 + "?s=13&amp;d=retro' width='13' height='13' alt='Gravatar' /> " + text)
-- 
1.8.5.2



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] email-gravatar: fix html syntax issues
  2014-01-15 12:39 [PATCH 1/1] email-gravatar: fix html syntax issues mail
@ 2014-01-15 13:43 ` Jason
  2014-01-15 13:52   ` list
  0 siblings, 1 reply; 3+ messages in thread
From: Jason @ 2014-01-15 13:43 UTC (permalink / raw)


Jimminy cricket. Okay, merged.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20140115/d3a22cdd/attachment.html>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] email-gravatar: fix html syntax issues
  2014-01-15 13:43 ` Jason
@ 2014-01-15 13:52   ` list
  0 siblings, 0 replies; 3+ messages in thread
From: list @ 2014-01-15 13:52 UTC (permalink / raw)


"Jason A. Donenfeld" <Jason at zx2c4.com> on Wed, 2014/01/15 14:43:
> Jimminy cricket. Okay, merged.

I would have been ok with that, but validator.w3c.org gives errors. ;)
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20140115/76af3f17/attachment.asc>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-01-15 13:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-15 12:39 [PATCH 1/1] email-gravatar: fix html syntax issues mail
2014-01-15 13:43 ` Jason
2014-01-15 13:52   ` list

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).