maintenance release coming soon

maintenance release coming soon

[Jason]

Hey guys,

Last release was huge. A handful of little commits fixing small bugs
has been piling up since our last big feature release. So I think
sometime toward the end of next week, I'm going to release a 0.10.1
for bug fixes. Nothing huge. Nothing with big press releases and
noise. Just something to clean things up. So, if you've got any bug
fixes sitting around in your queue, push them to the top of the
mailing list early next week.

Thanks,
Jason

maintenance release coming soon

[list]

"Jason A. Donenfeld" <Jason at zx2c4.com> on Thu, 2014/02/20 20:10:
> Hey guys,
> 
> Last release was huge. A handful of little commits fixing small bugs
> has been piling up since our last big feature release. So I think
> sometime toward the end of next week, I'm going to release a 0.10.1
> for bug fixes. Nothing huge. Nothing with big press releases and
> noise. Just something to clean things up. So, if you've got any bug
> fixes sitting around in your queue, push them to the top of the
> mailing list early next week.

Do you want to go with git 1.9.0 or keep 1.8.5 for this maintenance release?

I think I discovered a bug yesterday, but did not have any time to look into
that. I will return with a patch if I can reproduce.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20140220/8853c864/attachment-0001.asc>

maintenance release coming soon

[Jason]

On Thu, Feb 20, 2014 at 8:33 PM, Christian Hesse <list at eworm.de> wrote:
>
> Do you want to go with git 1.9.0 or keep 1.8.5 for this maintenance release?

I'd love to pop it up to 1.9.0, as well. AFAIK, nothing drastic
happens, but I haven't looked into it. If you'd like to provide a
patch for that, t'would be much appreciated.

>
> I think I discovered a bug yesterday, but did not have any time to look into
> that. I will return with a patch if I can reproduce.

Oh my, okay. What behavior? I just fixed this bug
<http://git.zx2c4.com/cgit/commit/?id=7e1c0ed2a>... maybe you saw the
same.

[PATCH 1/1] print download link for reference string length == 1

[mail]

I have a number of repositories that start tagging with just '1' and
count up. Actually references with sting length of one are skipped, this
patch changes that.
---
 ui-refs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui-refs.c b/ui-refs.c
index 147b665..e8e308e 100644
--- a/ui-refs.c
+++ b/ui-refs.c
@@ -105,7 +105,7 @@ static void print_tag_downloads(const struct cgit_repo *repo, const char *ref)
 	const char *basename;
 	int free_ref = 0;
 
-	if (!ref || strlen(ref) < 2)
+	if (!ref || strlen(ref) < 1)
 		return;
 
 	basename = cgit_repobasename(repo->url);
-- 
1.9.0

maintenance release coming soon

[list]

"Jason A. Donenfeld" <Jason at zx2c4.com> on Thu, 2014/02/20 20:35:
> On Thu, Feb 20, 2014 at 8:33 PM, Christian Hesse <list at eworm.de> wrote:
> >
> > Do you want to go with git 1.9.0 or keep 1.8.5 for this maintenance
> > release?
> 
> I'd love to pop it up to 1.9.0, as well. AFAIK, nothing drastic
> happens, but I haven't looked into it. If you'd like to provide a
> patch for that, t'would be much appreciated.

Sure, just testing some more. Stay tuned.

> > I think I discovered a bug yesterday, but did not have any time to look
> > into that. I will return with a patch if I can reproduce.
> 
> Oh my, okay. What behavior? I just fixed this bug
> <http://git.zx2c4.com/cgit/commit/?id=7e1c0ed2a>... maybe you saw the
> same.

No, the patch has made its way to the mailing list already. ;)
I will reply there.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20140220/22ea5ec2/attachment.asc>

[PATCH 1/1] print download link for reference string length == 1

[list]

Christian Hesse <mail at eworm.de> on Thu, 2014/02/20 20:48:
> I have a number of repositories that start tagging with just '1' and
> count up. Actually references with sting length of one are skipped, this
> patch changes that.

Wondering if there was a good reason to use a minimum string length of two...
Can my patch break anything? As far as I can tell is works without problems
for me.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20140220/c67ec3cd/attachment.asc>

[PATCH 1/1] print download link for reference string length == 1

[cgit]

On Thu, 20 Feb 2014 at 20:58:53, Christian Hesse wrote:
> Christian Hesse <mail at eworm.de> on Thu, 2014/02/20 20:48:
> > I have a number of repositories that start tagging with just '1' and
> > count up. Actually references with sting length of one are skipped, this
> > patch changes that.
> 
> Wondering if there was a good reason to use a minimum string length of two...
> Can my patch break anything? As far as I can tell is works without problems
> for me.

I can only guess because this code was added when the function was
introduced in commit 65962685 (ui-refs.c: show download links for all
tags referring to commit objects, 2008-12-01). I think it is related to
the code below accessing ref[1], though. I don't see how anything could
go wrong when the string length is 1 since isdigit('\0') should return
0 in that case. +1 from me.

> -- 
> main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
> "CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
> putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
> 
> 
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/cgit

[PATCH 1/1] print download link for reference string length == 1

[Jason]

Lukas' analysis seems correct to me. Merging.