From: list at eworm.de (Christian Hesse)
Subject: [PATCH 1/1] git: preview for v2.3.0-rc0
Date: Tue, 13 Jan 2015 10:57:39 +0100 [thread overview]
Message-ID: <20150113105739.1043e130@leda.localdomain> (raw)
In-Reply-To: <20150113094353.GD26383@serenity.lan>
John Keeping <john at keeping.me.uk> on Tue, 2015/01/13 09:43:
> On Tue, Jan 13, 2015 at 09:56:47AM +0100, list at eworm.de wrote:
> > From: Christian Hesse <mail at eworm.de>
> >
> > * sort_string_list(): rename to string_list_sort() (upstream commit
> > 3383e199)
> > * update read_tree_recursive callback to pass strbuf as base (upstream
> > commit 6a0b0b6d)
> >
> > Signed-off-by: Christian Hesse <mail at eworm.de>
> > ---
> > [...]
>
> Is there any benefit to introducing a new function here? In other
> words, is walk_tree() used anywhere else? If not, wouldn't it be
> simpler to update the signature of the existing function?
>
> (The same comment applies to several other places below.)
I just adopted the changes from git upstream to make things work. This is not
intended for merge... And I will take a closer look for final patch when
git v2.3.0 arrives. ;)
Our code include three functions called 'walk_tree()' in ui-plain.c,
ui-blob.c and ui-tree.c. Can this bring any trouble?
--
main(a){char*c=/* Schoene Gruesse */"B?IJj;MEH"
"CX:;",b;for(a/* Chris get my mail address: */=0;b=c[a++];)
putchar(b-1/(/* gcc -o sig sig.c && ./sig */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20150113/2a68cb7a/attachment.asc>
next prev parent reply other threads:[~2015-01-13 9:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 8:56 list
2015-01-13 9:43 ` john
2015-01-13 9:57 ` list [this message]
2015-01-13 10:09 ` john
2015-01-14 15:34 ` [PATCH v2 " list
2015-01-15 22:01 ` john
2015-01-16 8:33 ` list
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150113105739.1043e130@leda.localdomain \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).