List for cgit developers and users
 help / color / mirror / Atom feed
From: john at keeping.me.uk (John Keeping)
Subject: [PATCH] ui-commit: display commit notes as 'raw'
Date: Fri, 20 Mar 2015 21:29:50 +0000	[thread overview]
Message-ID: <20150320212950.GA1344@serenity> (raw)
In-Reply-To: <1426869593-10432-1-git-send-email-stefan.naewe@gmail.com>

On Fri, Mar 20, 2015 at 05:39:53PM +0100, Stefan Naewe wrote:
> When the git function format_display_notes() is called
> with a value != 0 as the last argument ('raw') the notes text
> gets displayed w/o an additional 'Notes:' header. This seems
> to be better suited for our needs since we're already displaying
> a similar header.

What happens when there are multiple display notes refs?  It seems that
without "raw", format_note() puts the name of the ref in the header it
prints (if it's not the default notes ref).

It's possible that the correct answer is that we don't care about that
case, but it is potentially a regression for people who want to display
multiple notes.

> Signed-off-by: Stefan Naewe <stefan.naewe at gmail.com>
> ---
>  ui-commit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ui-commit.c b/ui-commit.c
> index d5a888d..4b40133 100644
> --- a/ui-commit.c
> +++ b/ui-commit.c
> @@ -37,7 +37,7 @@ void cgit_print_commit(char *hex, const char *prefix)
>  	}
>  	info = cgit_parse_commit(commit);
>  
> -	format_display_notes(sha1, &notes, PAGE_ENCODING, 0);
> +	format_display_notes(sha1, &notes, PAGE_ENCODING, 1);
>  
>  	load_ref_decorations(DECORATE_FULL_REFS);
>  


  reply	other threads:[~2015-03-20 21:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 16:39 stefan.naewe
2015-03-20 21:29 ` john [this message]
2015-03-21 13:11   ` stefan.naewe
2015-03-21 13:19     ` john
2015-03-21 15:37       ` stefan.naewe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150320212950.GA1344@serenity \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).