List for cgit developers and users
 help / color / mirror / Atom feed
From: john at keeping.me.uk (John Keeping)
Subject: disable logo-link ?
Date: Thu, 18 Jun 2015 16:07:35 +0100	[thread overview]
Message-ID: <20150618150735.GN18226@serenity.lan> (raw)
In-Reply-To: <CAC1BbcQpzbBmtcG4tUjeRvVT4OZQtNg1hP_eWXrcfs-bcEzhUw@mail.gmail.com>

On Thu, Jun 18, 2015 at 05:03:35PM +0200, Bernhard Reutner-Fischer wrote:
> On 18 June 2015 at 16:48, John Keeping <john at keeping.me.uk> wrote:
> > On Thu, Jun 18, 2015 at 04:38:32PM +0200, Bernhard Reutner-Fischer wrote:
> >> A colleague asked if it's possible to disable the logo-link, but that
> >> doesn't seem to work right now?
> >
> > No, if there isn't a logo-link specified then the CGit root URL is used;
> > see ui-shared.c:
> >
> >         if (logo_link && *logo_link)
> >                 html_attr(logo_link);
> >         else
> >                 html_attr(cgit_rooturl());
> 
> yes, anyone got an idea on a token to disable it?
> 
> maybe:
> logo-link=

It looks like that would have (sort of) worked prior to commit 808c685
(implement repo.logo and repo.logo-link, 2010-12-23), although it would
have had "href=''" in the generated HTML.

> As a second "issue", what about a logo-alt instead of the hardcoded
>                 html("'><img src='");
>                 html_attr(logo);
>                 html("' alt='cgit logo'/></a></td>\n");
> 
> in print_header() ?

Good idea.


  reply	other threads:[~2015-06-18 15:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18 14:38 rep.dot.nop
2015-06-18 14:48 ` john
2015-06-18 15:03   ` rep.dot.nop
2015-06-18 15:07     ` john [this message]
2015-06-18 15:13       ` rep.dot.nop
2015-06-19 10:37         ` [PATCH] Implement logo-alt rep.dot.nop
2016-06-09 15:27           ` rep.dot.nop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150618150735.GN18226@serenity.lan \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).