From: john at keeping.me.uk (John Keeping)
Subject: XSS in cgit
Date: Thu, 14 Jan 2016 10:57:23 +0000 [thread overview]
Message-ID: <20160114105723.GH14056@serenity.lan> (raw)
In-Reply-To: <CAHmME9pf_TjMHYiNuqC4fF5i69w+ntV+Rgv_Tt5c2Y7MnCtgKA@mail.gmail.com>
On Wed, Jan 13, 2016 at 05:07:12PM +0100, Jason A. Donenfeld wrote:
> First (1), the big bad one. In ui-blob.c, we have:
>
> ctx.page.mimetype = ctx.qry.mimetype;
> cgit_print_http_headers();
>
> This invokes, from ui-shared.c:
> htmlf("Content-Type: %s\n", ctx.page.mimetype);
> or
> htmlf("Content-Type: %s; charset=%s\n", ctx.page.mimetype, ctx.page.charset);
>
>
> A malicious user can pass a mime type such as text/html followed by a
> few new lines and then some malicious javascript in a script tag to
> launch an XSS attack. The obvious solution here is to ensure
> ctx.page.mimetype doesn't contain new lines, null characters, and
> other naughty fields according to the HTTP spec.
I wonder if we should just drop support for the "mimetype" query
parameter and see if anyone complains. In general, I would expect it to
be the server's responsibility to decide on the type of its output and
allowing the client to override it seems like a problem in general.
next prev parent reply other threads:[~2016-01-14 10:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 16:07 Jason
2016-01-13 19:11 ` normalperson
2016-01-15 11:34 ` Jason
2016-01-15 15:18 ` Jason
[not found] ` <7B8B10EF-8DCA-4115-9D33-4DD56F670BAB@klever.net>
2016-01-16 0:23 ` Jason
2016-01-16 9:38 ` john
2016-01-17 16:23 ` Fwd: " Jason
2016-01-14 10:57 ` john [this message]
2016-01-14 11:01 ` Jason
2016-01-14 11:07 ` john
2016-01-14 11:53 ` mailings
2016-01-14 12:59 ` Jason
2016-01-14 13:35 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160114105723.GH14056@serenity.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).