From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: XSS in cgit
Date: Fri, 15 Jan 2016 16:18:59 +0100 [thread overview]
Message-ID: <CAHmME9odymyXwoAT2qtuvVciEAdGLK44bzyumRf+yPWaVnJkZQ@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9qJA5q_n2-+mRsh6tqNdXtRd5e_28JFFQF4RTKjKHjaxQ@mail.gmail.com>
Hi Michael,
Care to enlighten us what the use case behind 42effc9 [1] was?
Thanks,
Jason
[1] http://git.zx2c4.com/cgit/commit/?id=42effc939090b2fbf1b2b76cd1d9c30fabcd230e
On Fri, Jan 15, 2016 at 12:34 PM, Jason A. Donenfeld <Jason at zx2c4.com> wrote:
>
> On Jan 13, 2016 9:11 PM, "Eric Wong" <normalperson at yhbt.net> wrote:
>>
>> "Jason A. Donenfeld" <Jason at zx2c4.com> wrote:
>> > Given all this, could somebody remind me why we have both /plain and
>> > /blob handlers? And if it's still necessary to maintain a distinction?
>> > If not, I will gladly accept patches to unify these.
>>
>> IIRC, the main difference was blob allows serving tree objects
>> as-is in binary form while plain generates an HTML directory listing.
>
> Thanks, this is what I thought, which leads me to the more relevant
> question:
>
> Given that the /blob handler returns binary directory data, it must conform
> to a particular API in order to be useful. Was the recently removed
> /blob/?mimetype= query string parameter part of such an API? Have we maimed
> something useful?
next prev parent reply other threads:[~2016-01-15 15:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 16:07 Jason
2016-01-13 19:11 ` normalperson
2016-01-15 11:34 ` Jason
2016-01-15 15:18 ` Jason [this message]
[not found] ` <7B8B10EF-8DCA-4115-9D33-4DD56F670BAB@klever.net>
2016-01-16 0:23 ` Jason
2016-01-16 9:38 ` john
2016-01-17 16:23 ` Fwd: " Jason
2016-01-14 10:57 ` john
2016-01-14 11:01 ` Jason
2016-01-14 11:07 ` john
2016-01-14 11:53 ` mailings
2016-01-14 12:59 ` Jason
2016-01-14 13:35 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9odymyXwoAT2qtuvVciEAdGLK44bzyumRf+yPWaVnJkZQ@mail.gmail.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).