From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 3/3] Add support for git's mailmap.
Date: Mon, 29 Aug 2016 17:04:18 +0100 [thread overview]
Message-ID: <20160829160418.m33ncedwrtqwkizr@john.keeping.me.uk> (raw)
In-Reply-To: <aaf5e435-e402-dbb9-40d6-4dcfe4ec94cf@bnl.gov>
On Mon, Aug 29, 2016 at 11:18:16AM -0400, Jason A. Smith wrote:
> On 08/26/2016 07:13 PM, John Keeping wrote:
> > On Fri, Aug 26, 2016 at 05:30:32PM -0400, Jason A. Smith wrote:
> >>
> >> Sorry for the extra email noise, but while fixing these I found two more
> >> cgit_open_filter() function calls that should probably be changed to
> >> cgit_open_email_filter() in the first patch:
> >>
> >> ui-refs.c:146
> >> ui-tag.c:85
> >
> > Those both use tagger_email, so that makes sense, I completely forgot
> > about that one and only converted author_email and committer_email.
> >
> > The reference in ui-tag.c also needs angle brackets inserted in the
> > output in the !noplainemail case. Feel free to squash that into the
> > first patch, and take ownership if you want.
>
> I fixed both of these and squashed them into your commits since they
> were very minor changes.
>
> > I also noticed that we don't check the return value of read_mailmap(),
> > I'm not entirely sure what we should do if it fails, but it does look
> > like "missing mailmap" is not a failure case, so we probably should be
> > doing something if it returns an error.
>
> I am going to update the 3rd mailmap commit now. What would you suggest
> doing if there is an error reading the mailmap file? Should it call
> cgit_print_error_page() or is that too much and instead just log an
> error message to stderr so it goes into the web server's error logs?
>
> I looked at the git sources and didn't see any examples of any other
> code checking for errors returned by read_mailmap()
Printing to stderr seems reasonable. As a user there's nothing more
annoying than observing the something isn't working (for example, the
mailmap isn't being applied) and having no way of telling where the
error is, so printing a warning if read_mailmap() fails seems like the
right thing to do.
next prev parent reply other threads:[~2016-08-29 16:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 20:12 smithj4
2016-08-26 21:10 ` smithj4
2016-08-26 21:30 ` smithj4
2016-08-26 23:13 ` john
2016-08-29 15:18 ` smithj4
2016-08-29 16:04 ` john [this message]
2016-08-30 2:58 ` Jason
[not found] <b710a9bcd7a1408c429ec09f535916074b957d25.1472494937.git.smithj4@bnl.gov>
2016-08-29 18:28 ` smithj4
[not found] <cover.1487952449.git.smithj4@bnl.gov>
2017-02-24 16:19 ` smithj4
2017-02-25 16:12 [PATCH 0/3] " smithj4
2017-02-25 16:12 ` [PATCH 3/3] " smithj4
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829160418.m33ncedwrtqwkizr@john.keeping.me.uk \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).