List for cgit developers and users
 help / color / mirror / Atom feed
From: smithj4 at bnl.gov (Jason A. Smith)
Subject: [PATCH 3/3] Add support for git's mailmap.
Date: Fri, 26 Aug 2016 17:30:32 -0400	[thread overview]
Message-ID: <e5712f0a-7489-0e4f-08c2-5a89bfe65ce1@bnl.gov> (raw)
In-Reply-To: <e4bdceb2-734f-cdc5-dc76-052e6c4beb57@bnl.gov>

On 08/26/2016 05:10 PM, Jason A. Smith wrote:
> On 08/26/2016 04:12 PM, Jason A. Smith wrote:
>>
>> If a mailmap file is present in the repo, it will be used to coalesce
>> commits by the same person, just like git does. When no mailmap file is
>> found then it functions as before.
>>
>> Signed-off-by: Jason A. Smith <smithj4 at bnl.gov>
>> ---
>>  cgit.h      |  2 ++
>>  parsing.c   | 11 +++++++++++
>>  ui-atom.c   | 20 ++++++++++++++------
>>  ui-commit.c | 22 ++++++++++++++++------
>>  ui-log.c    | 11 +++++++++--
>>  ui-refs.c   | 27 +++++++++++++++++++++------
>>  ui-stats.c  | 13 ++++++++++---
>>  7 files changed, 83 insertions(+), 23 deletions(-)
>
> Sorry, I forgot the --thread flag. I also just noticed that the branch
> and thread lists on the summary page still do not honor the mailmap
> because there is no general init type function in ui-refs to put the
> read_mailmap() call, and I noticed that ui-tag also has tagger name &
> email so that should be patched as well. I will have to fix these and
> resend the patches, probably on Monday.
>
> ~Jason

Sorry for the extra email noise, but while fixing these I found two more 
cgit_open_filter() function calls that should probably be changed to 
cgit_open_email_filter() in the first patch:

ui-refs.c:146
ui-tag.c:85

~Jason


  reply	other threads:[~2016-08-26 21:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26 20:12 smithj4
2016-08-26 21:10 ` smithj4
2016-08-26 21:30   ` smithj4 [this message]
2016-08-26 23:13     ` john
2016-08-29 15:18       ` smithj4
2016-08-29 16:04         ` john
2016-08-30  2:58           ` Jason
     [not found] <b710a9bcd7a1408c429ec09f535916074b957d25.1472494937.git.smithj4@bnl.gov>
2016-08-29 18:28 ` smithj4
     [not found] <cover.1487952449.git.smithj4@bnl.gov>
2017-02-24 16:19 ` smithj4
2017-02-25 16:12 [PATCH 0/3] " smithj4
2017-02-25 16:12 ` [PATCH 3/3] " smithj4

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5712f0a-7489-0e4f-08c2-5a89bfe65ce1@bnl.gov \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).