From: list at eworm.de (Christian Hesse)
Subject: [PATCH 1/1] ui-log: fix data corruption
Date: Fri, 7 Oct 2016 23:25:55 +0200 [thread overview]
Message-ID: <20161007232555.437610b8@leda.localdomain> (raw)
In-Reply-To: <20161007232123.5d7e8789@leda.localdomain>
Christian Hesse <list at eworm.de> on Fri, 2016/10/07 23:21:
> "Jason A. Donenfeld" <Jason at zx2c4.com> on Fri, 2016/10/07 21:43:
> > Does this ever get freed, though?
>
> I ran cgit in valgrind with this patch applied. No changes in what is lost -
> so looks like this is freed later on.
Another thought on this... The issue reported by Sylvain Rabot
shows that get_revision() can not get the same commit again. This is an
indication we do free something we should not touch, no?
--
main(a){char*c=/* Schoene Gruesse */"B?IJj;MEH"
"CX:;",b;for(a/* Best regards my address: */=0;b=c[a++];)
putchar(b-1/(/* Chris cc -ox -xc - && ./x */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20161007/559985fa/attachment-0001.asc>
next prev parent reply other threads:[~2016-10-07 21:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 13:35 list
2016-10-07 19:43 ` Jason
2016-10-07 21:21 ` list
2016-10-07 21:25 ` list [this message]
2016-10-09 11:26 ` john
2016-10-10 14:00 ` list
2016-10-12 11:23 ` Jason
2016-10-16 11:54 ` john
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007232555.437610b8@leda.localdomain \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).