From: john at keeping.me.uk (John Keeping)
Subject: [PATCH v8 1/1] ui-shared: allow to split the repository link
Date: Sun, 12 Mar 2017 18:02:24 +0000 [thread overview]
Message-ID: <20170312180224.GN2102@john.keeping.me.uk> (raw)
In-Reply-To: <20170312175602.7mxqwckrfz26ioac@x230>
On Sun, Mar 12, 2017 at 06:56:03PM +0100, Petr Vorel wrote:
> > Teach cgit split the repository link in the top of repository "summary"
> > view. This emulates the same behaviour as it's in gitweb.
>
> > This behaviour is not implemented for repositories which have
> > "repo.name" set different than "repo.url".
>
> > Signed-off-by: Petr Vorel <petr.vorel at gmail.com>
> > Cc: "Jason A. Donenfeld" <Jason at zx2c4.com>
> > Cc: John Keeping <john at keeping.me.uk>
> > Reviewed-by: John Keeping <john at keeping.me.uk>
> > ---
> > cgitrc.5.txt | 4 +++-
> > ui-shared.c | 28 +++++++++++++++++++++++++++-
> > 2 files changed, 30 insertions(+), 2 deletions(-)
>
> > ---
> > v7->v8: add missing free().
> actually, this breaks even more tests, please use v7.
> Patch v7 breaks t0103-log.sh, but v8 breaks even some tests before: t0104-tree.sh.
> Failure is in "summary, refs, log, tree, commit, diff" links
>
> John, I suppose free() shouldn't be used. Or am I missing something and I should free
> something else?
It's the return value of cgit_repourl() that needs to be freed, not the
name. You'll need a new local variable for the result of calling
cgit_repourl() which then needs to be freed in the loop.
next prev parent reply other threads:[~2017-03-12 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-12 17:00 petr.vorel
2017-03-12 17:56 ` petr.vorel
2017-03-12 18:02 ` john [this message]
2017-03-12 18:13 ` petr.vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170312180224.GN2102@john.keeping.me.uk \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).