From: petr.vorel at gmail.com (Petr Vorel)
Subject: [PATCH v8 1/1] ui-shared: allow to split the repository link
Date: Sun, 12 Mar 2017 19:13:53 +0100 [thread overview]
Message-ID: <20170312181353.oixmk3zccdnjabve@x230> (raw)
In-Reply-To: <20170312180224.GN2102@john.keeping.me.uk>
Hi John,
> It's the return value of cgit_repourl() that needs to be freed, not the
> name. You'll need a new local variable for the result of calling
> cgit_repourl() which then needs to be freed in the loop.
Thanks! Fixed in v9.
I ignored t0103-log.sh test failures you mentioned while commenting v7 as you've already
proposed a fix (thanks!).
Kind regards,
Petr
prev parent reply other threads:[~2017-03-12 18:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-12 17:00 petr.vorel
2017-03-12 17:56 ` petr.vorel
2017-03-12 18:02 ` john
2017-03-12 18:13 ` petr.vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170312181353.oixmk3zccdnjabve@x230 \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).