From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 1/4] ui-blame: Distinguish hashes column from lines column
Date: Sat, 21 Oct 2017 15:33:22 +0100 [thread overview]
Message-ID: <20171021143322.GC2393@john.keeping.me.uk> (raw)
In-Reply-To: <20171018041735.31592-2-whydoubt@gmail.com>
On Tue, Oct 17, 2017 at 11:17:32PM -0500, Jeff Smith wrote:
> Signed-off-by: Jeff Smith <whydoubt at gmail.com>
Reviewed-by: John Keeping <john at keeping.me.uk>
> ---
> cgit.css | 1 +
> ui-blame.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/cgit.css b/cgit.css
> index 836f8ae..893ebeb 100644
> --- a/cgit.css
> +++ b/cgit.css
> @@ -300,6 +300,7 @@ div#cgit table.blob {
> border-top: solid 1px black;
> }
>
> +div#cgit table.blob td.hashes,
> div#cgit table.blob td.lines {
> margin: 0; padding: 0 0 0 0.5em;
> vertical-align: top;
> diff --git a/ui-blame.c b/ui-blame.c
> index 62cf431..a5ac590 100644
> --- a/ui-blame.c
> +++ b/ui-blame.c
> @@ -51,7 +51,7 @@ static void emit_blame_entry(struct blame_scoreboard *sb,
>
> char *detail = emit_suspect_detail(suspect);
>
> - html("<tr><td class='sha1 lines'>");
> + html("<tr><td class='sha1 hashes'>");
> cgit_commit_link(find_unique_abbrev(oid->hash, DEFAULT_ABBREV), detail,
> NULL, ctx.qry.head, oid_to_hex(oid), suspect->path);
> html("</td>\n");
next prev parent reply other threads:[~2017-10-21 14:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 4:17 [PATCH 0/4] Add ui-blame syntax highlighting whydoubt
2017-10-18 4:17 ` [PATCH 1/4] ui-blame: Distinguish hashes column from lines column whydoubt
2017-10-21 14:33 ` john [this message]
2017-10-18 4:17 ` [PATCH 2/4] ui-blame: Break out emit_blame_entry into component methods whydoubt
2017-10-21 14:33 ` john
2017-10-18 4:17 ` [PATCH 3/4] ui-blame: Make each column into a single table cell whydoubt
2017-10-21 14:34 ` john
2017-10-18 4:17 ` [PATCH 4/4] ui-blame: Allow syntax highlighting whydoubt
2017-10-21 14:43 ` john
2017-10-21 21:53 ` whydoubt
2017-10-24 14:30 ` Jason
2017-10-29 2:23 ` [PATCH 4/4 v2] " whydoubt
2017-10-29 2:26 ` whydoubt
2017-10-29 2:43 ` [PATCH 4/4 v3] " whydoubt
2017-10-29 22:23 ` Jason
2017-11-05 12:36 ` john
2018-01-19 10:41 ` [PATCH 0/4] Add ui-blame " Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021143322.GC2393@john.keeping.me.uk \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).