List for cgit developers and users
 help / color / mirror / Atom feed
From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 4/4 v3] ui-blame: Allow syntax highlighting
Date: Sun, 5 Nov 2017 12:36:10 +0000	[thread overview]
Message-ID: <20171105123610.GD2348@john.keeping.me.uk> (raw)
In-Reply-To: <CAHmME9piw=dJ1Kmgnh+qgux+iLxERvZ7Cxiie0G94A=bsoUftA@mail.gmail.com>

On Sun, Oct 29, 2017 at 11:23:38PM +0100, Jason A. Donenfeld wrote:
> Works remarkably well. Excellent work. Example, for others on the list:
> 
> https://git.zx2c4.com/WireGuard/blame/src/noise.c
> 
> Pending objections from others, I'll merge this from jd/color-blame to
> master in a few days.

This version looks great to me, so I say merge away!


  reply	other threads:[~2017-11-05 12:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-18  4:17 [PATCH 0/4] Add ui-blame " whydoubt
2017-10-18  4:17 ` [PATCH 1/4] ui-blame: Distinguish hashes column from lines column whydoubt
2017-10-21 14:33   ` john
2017-10-18  4:17 ` [PATCH 2/4] ui-blame: Break out emit_blame_entry into component methods whydoubt
2017-10-21 14:33   ` john
2017-10-18  4:17 ` [PATCH 3/4] ui-blame: Make each column into a single table cell whydoubt
2017-10-21 14:34   ` john
2017-10-18  4:17 ` [PATCH 4/4] ui-blame: Allow syntax highlighting whydoubt
2017-10-21 14:43   ` john
2017-10-21 21:53     ` whydoubt
2017-10-24 14:30       ` Jason
2017-10-29  2:23         ` [PATCH 4/4 v2] " whydoubt
2017-10-29  2:26           ` whydoubt
2017-10-29  2:43             ` [PATCH 4/4 v3] " whydoubt
2017-10-29 22:23               ` Jason
2017-11-05 12:36                 ` john [this message]
2018-01-19 10:41 ` [PATCH 0/4] Add ui-blame " Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171105123610.GD2348@john.keeping.me.uk \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).