From: john at keeping.me.uk (John Keeping)
Subject: The logo of the about page is never shown although it is displayed on all other pages
Date: Sat, 25 Aug 2018 18:39:49 +0100 [thread overview]
Message-ID: <20180825173949.GC824@john.keeping.me.uk> (raw)
In-Reply-To: <CAKcFC3YNTf_uQo4USbaB1JNmyHz-9yYg7dNZKG8Rk9xEftpJSQ@mail.gmail.com>
On Sat, Aug 25, 2018 at 04:24:15PM +0200, jean-christophe manciot wrote:
> Something strange happened.
> I played with some settings to find a workaround, and the issue vanished
> suddenly:
> I was careful about the a 'cache-about-ttl=1' parameter to make sure the
> cache was not involved in this.
> I refreshed the about page several times during a few mins, but the issue
> was still there.
> I added a 'homepage=https://git.sdxlive.com/<repository_name>/about' in the
> cgitrc file of all the repos and after some time (more than 1 mn), the
> issue was gone.
This sounds like a cache issue somewhere, whether that's CGit or your
browser or somewhere in between. If the cache TTL was originally
longer, then that will have been included in the HTTP Expires header on
earlier results so it's possible that the older response was still
cached based on the previous TTL.
> On Sat, Aug 25, 2018 at 11:50 AM John Keeping <john at keeping.me.uk> wrote:
>
> > On Sat, Aug 25, 2018 at 09:41:44AM +0200, jean-christophe manciot wrote:
> > > I use *v1.2.1* with the patch regarding the table of contents
> > > <
> > https://git.zx2c4.com/cgit/diff/filters/html-converters/md2html?h=ch/anchorlinks&id=42e70dcbe84e128ba23a25918e3d5d9aac656dc6
> > >
> > > .
> > > I have the following setup:
> > > /etc/cgitrc:
> > > logo=/cgit-css/cgit.png
> > >
> > > Each repo has its own cgitrc, for instance:
> > > logo=https://git.sdxlive.com/PPA/plain/logo.png
> > > logo-link=https://help.ubuntu.com/lts/serverguide/index.html
> > >
> > > The logo is displayed correctly on all pages (summary, refs, log, ...)
> > > except on the about page where I get:
> >
> > Can you share a public URL demonstrating the problem?
> >
> > The code for outputting the page header (including the logo) is shared
> > for all pages so I can't see why it would output a broken link just on
> > the about page.
> >
>
>
> --
> Jean-Christophe
prev parent reply other threads:[~2018-08-25 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-25 7:41 actionmystique
2018-08-25 9:50 ` john
2018-08-25 14:24 ` actionmystique
2018-08-25 17:39 ` john [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180825173949.GC824@john.keeping.me.uk \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).