[PATCH 1/1] css: Change #git font-size to 13px

[PATCH 1/1] css: Change #git font-size to 13px

[petr.vorel]

Previous size font-size 10pt (which is 13.3333px) hide underscore,
when used with highlight with background-color on modified lines.
Here underscore of crypto_blkcipher is hidden on by background color of
newly added line.

 struct p8_aes_ctr_ctx {
-	struct crypto_blkcipher *fallback;
+	struct crypto_skcipher *fallback;
 	struct aes_key enc_key;
 };

Signed-off-by: Petr Vorel <petr.vorel at gmail.com>
---
This found on kernel cgit, tested locally. See:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-4.14/crypto-vmx-use-skcipher-for-ctr-fallback.patch


Kind regards,
Petr
---
 cgit.css | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cgit.css b/cgit.css
index d4aadbf..be4011a 100644
--- a/cgit.css
+++ b/cgit.css
@@ -2,7 +2,7 @@ div#cgit {
 	padding: 0em;
 	margin: 0em;
 	font-family: sans-serif;
-	font-size: 10pt;
+	font-size: 13px;
 	color: #333;
 	background: white;
 	padding: 4px;
-- 
2.18.0

[PATCH 1/1] css: Change #git font-size to 13px

[john]

On Sun, Aug 26, 2018 at 02:59:36PM +0200, Petr Vorel wrote:
> Previous size font-size 10pt (which is 13.3333px) hide underscore,
> when used with highlight with background-color on modified lines.
> Here underscore of crypto_blkcipher is hidden on by background color of
> newly added line.
> 
>  struct p8_aes_ctr_ctx {
> -	struct crypto_blkcipher *fallback;
> +	struct crypto_skcipher *fallback;
>  	struct aes_key enc_key;
>  };
> 
> Signed-off-by: Petr Vorel <petr.vorel at gmail.com>
> ---
> This found on kernel cgit, tested locally. See:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-4.14/crypto-vmx-use-skcipher-for-ctr-fallback.patch

Which browser do you see this with?

I've tried Firefox 61.0 and Chromium 69.0.3497.42 against that page and
I can't reproduce the bug you describe.

I'm not necessarily opposed to the change below, but it feels like this
is working around a browser bug rather than fixing a fundamental issue
with the design of the page.

> ---
>  cgit.css | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cgit.css b/cgit.css
> index d4aadbf..be4011a 100644
> --- a/cgit.css
> +++ b/cgit.css
> @@ -2,7 +2,7 @@ div#cgit {
>  	padding: 0em;
>  	margin: 0em;
>  	font-family: sans-serif;
> -	font-size: 10pt;
> +	font-size: 13px;
>  	color: #333;
>  	background: white;
>  	padding: 4px;
> -- 
> 2.18.0

[PATCH 1/1] css: Change #git font-size to 13px

[petr.vorel]

Hi John,

> > This found on kernel cgit, tested locally. See:
> > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-4.14/crypto-vmx-use-skcipher-for-ctr-fallback.patch

> Which browser do you see this with?

> I've tried Firefox 61.0 and Chromium 69.0.3497.42 against that page and
> I can't reproduce the bug you describe.

> I'm not necessarily opposed to the change below, but it feels like this
> is working around a browser bug rather than fixing a fundamental issue
> with the design of the page.
Indeed, it's ok on my 61.0.1.
But it's problematic on Chromium 68.0.3440.75.
I double checked zoom it's 100% (not less or more).
The problem is appearing in file path as well (a/drivers/crypto/vmx/aes_ctr.c) :(.
I don't like browser workarounds either. It might be fixed in 69.x.

Kind regards,
Petr

[PATCH 1/1] css: Change #git font-size to 13px

[petr.vorel]

Hi John,

> > > This found on kernel cgit, tested locally. See:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-4.14/crypto-vmx-use-skcipher-for-ctr-fallback.patch

> > Which browser do you see this with?

> > I've tried Firefox 61.0 and Chromium 69.0.3497.42 against that page and
> > I can't reproduce the bug you describe.

> > I'm not necessarily opposed to the change below, but it feels like this
> > is working around a browser bug rather than fixing a fundamental issue
> > with the design of the page.
> Indeed, it's ok on my 61.0.1.
> But it's problematic on Chromium 68.0.3440.75.
> I double checked zoom it's 100% (not less or more).
> The problem is appearing in file path as well (a/drivers/crypto/vmx/aes_ctr.c) :(.
> I don't like browser workarounds either. It might be fixed in 69.x.

Issue persists also on Chromium 69.0.3497.81 (Debian).

Kind regards,
Petr