From: list at eworm.de (Christian Hesse)
Subject: [PATCH 1/1] ui-shared: add parentheses to suppress compiler warning
Date: Wed, 2 Jan 2019 17:27:02 +0100 [thread overview]
Message-ID: <20190102162702.8361-1-list@eworm.de> (raw)
From: Christian Hesse <mail at eworm.de>
warning: suggest parentheses around assignment used as
truth value [-Wparentheses]
Signed-off-by: Christian Hesse <mail at eworm.de>
---
ui-shared.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui-shared.c b/ui-shared.c
index 00d9ed1..6d1238d 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -1198,7 +1198,7 @@ void cgit_set_title_from_path(const char *path)
if (!path)
return;
- for (last_slash = path + strlen(path); slash = memrchr(path, '/', last_slash - path); last_slash = slash) {
+ for (last_slash = path + strlen(path); (slash = memrchr(path, '/', last_slash - path)); last_slash = slash) {
strbuf_add(&sb, slash + 1, last_slash - slash - 1);
strbuf_addstr(&sb, " \xc2\xab ");
}
reply other threads:[~2019-01-02 16:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190102162702.8361-1-list@eworm.de \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).