List for cgit developers and users
 help / color / Atom feed
From: list at eworm.de (Christian Hesse)
Subject: [PATCH 1/1] ui-shared: add parentheses to suppress compiler warning
Date: Wed,  2 Jan 2019 17:27:02 +0100
Message-ID: <20190102162702.8361-1-list@eworm.de> (raw)

From: Christian Hesse <mail at eworm.de>

warning: suggest parentheses around assignment used as
truth value [-Wparentheses]

Signed-off-by: Christian Hesse <mail at eworm.de>
---
 ui-shared.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui-shared.c b/ui-shared.c
index 00d9ed1..6d1238d 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -1198,7 +1198,7 @@ void cgit_set_title_from_path(const char *path)
 	if (!path)
 		return;
 
-	for (last_slash = path + strlen(path); slash = memrchr(path, '/', last_slash - path); last_slash = slash) {
+	for (last_slash = path + strlen(path); (slash = memrchr(path, '/', last_slash - path)); last_slash = slash) {
 		strbuf_add(&sb, slash + 1, last_slash - slash - 1);
 		strbuf_addstr(&sb, " \xc2\xab ");
 	}


                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190102162702.8361-1-list@eworm.de \
    --to= \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

List for cgit developers and users

Archives are clonable: git clone --mirror http://inbox.vuxu.org/cgit

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.cgit


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git