From: aklhfex at gmail.com (Chris Mayo)
Subject: [PATCH 0/5] SVG diffstat graphs and HTML5
Date: Mon, 18 Feb 2019 20:46:39 +0000 [thread overview]
Message-ID: <20190218204644.440-1-aklhfex@gmail.com> (raw)
diffstat graphs were not displaying correctly for me because their use of
inline style was being blocked by my content security policy. So I rewrote
them in SVG, which also saves a nested table and a padding element.
As part of checking this I ran the W3C Markup Validator, which reported
several HTML errors and warnings. Hence the rest of the patches here which
fix a number of errors and warnings, but not all e.g. ssdiff still causes
errors for reusing id's.
For the deprecated table summary attribute, not sure what the intent of this
was, I replaced with aria-label, if it was for accessibility.
Maybe "data-summary" instead?
Chris Mayo (5):
ui-diff: use SVG for diffstat graphs
Replace table summary attribute with aria-label
Replace self-closing syntax on non-void elements
ui-log,ui-refs: ensure there are cells for each column
ui-shared: add encoding declaration
cgit.css | 16 +++++-----------
tests/t0105-commit.sh | 2 +-
ui-commit.c | 2 +-
ui-diff.c | 26 +++++++++++++-------------
ui-log.c | 6 +++++-
ui-refs.c | 2 +-
ui-repolist.c | 2 +-
ui-shared.c | 1 +
ui-stats.c | 4 ++--
ui-summary.c | 2 +-
ui-tree.c | 8 ++++----
11 files changed, 35 insertions(+), 36 deletions(-)
--
2.20.1
next reply other threads:[~2019-02-18 20:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 20:46 aklhfex [this message]
2019-02-18 20:46 ` [PATCH 1/5] ui-diff: use SVG for diffstat graphs aklhfex
2019-02-18 20:46 ` [PATCH 2/5] Replace table summary attribute with aria-label aklhfex
2019-02-18 20:46 ` [PATCH 3/5] Replace self-closing syntax on non-void elements aklhfex
2019-02-18 20:46 ` [PATCH 4/5] ui-log,ui-refs: ensure there are cells for each column aklhfex
[not found] ` <CAGFiPxeyoWYT44SUOo-isKeErvYu-c4J78HtWnwse3ueKQV0fA@mail.gmail.com>
[not found] ` <CAGFiPxfmGgy0OVCnxNs6aY5RG9XNQGohOerv2Xu0GhV2KHpG5g@mail.gmail.com>
2019-02-18 21:15 ` [PATCH 4/5] ui-log, ui-refs: " 1melissadenee
2019-02-18 20:46 ` [PATCH 5/5] ui-shared: add encoding declaration aklhfex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218204644.440-1-aklhfex@gmail.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).