List for cgit developers and users
 help / color / mirror / Atom feed
From: aklhfex at gmail.com (Chris Mayo)
Subject: [PATCH 3/5] Replace self-closing syntax on non-void elements
Date: Mon, 18 Feb 2019 20:46:42 +0000	[thread overview]
Message-ID: <20190218204644.440-4-aklhfex@gmail.com> (raw)
In-Reply-To: <20190218204644.440-1-aklhfex@gmail.com>

Self-closing syntax not valid in HTML5 for normal elements, that could
contain content.

Signed-off-by: Chris Mayo <aklhfex at gmail.com>
---
 ui-diff.c  | 4 ++--
 ui-log.c   | 2 +-
 ui-stats.c | 4 ++--
 ui-tree.c  | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/ui-diff.c b/ui-diff.c
index eb0a395..62319e9 100644
--- a/ui-diff.c
+++ b/ui-diff.c
@@ -343,7 +343,7 @@ void cgit_print_diff_ctrls(void)
 	html("<form method='get'>");
 	cgit_add_hidden_formfields(1, 0, ctx.qry.page);
 	html("<table>");
-	html("<tr><td colspan='2'/></tr>");
+	html("<tr><td colspan='2'></tr>");
 	html("<tr>");
 	html("<td class='label'>context:</td>");
 	html("<td class='ctrl'>");
@@ -374,7 +374,7 @@ void cgit_print_diff_ctrls(void)
 	html_intoption(1, "ssdiff", curr);
 	html_intoption(2, "stat only", curr);
 	html("</select></td></tr>");
-	html("<tr><td/><td class='ctrl'>");
+	html("<tr><td><td class='ctrl'>");
 	html("<noscript><input type='submit' value='reload'/></noscript>");
 	html("</td></tr></table>");
 	html("</form>");
diff --git a/ui-log.c b/ui-log.c
index 3bcb657..cce4d5a 100644
--- a/ui-log.c
+++ b/ui-log.c
@@ -309,7 +309,7 @@ static void print_commit(struct commit *commit, struct rev_info *revs)
 			html("</td>\n");
 		}
 		else
-			html("<td/>"); /* Empty 'Age' column */
+			html("<td>"); /* Empty 'Age' column */
 
 		/* Print msgbuf into remainder of table row */
 		htmlf("<td colspan='%d'%s>\n", columns - (revs->graph ? 1 : 0),
diff --git a/ui-stats.c b/ui-stats.c
index 7acd358..f5a2b6e 100644
--- a/ui-stats.c
+++ b/ui-stats.c
@@ -391,7 +391,7 @@ void cgit_show_stats(void)
 	html("<b>stat options</b>");
 	html("<form method='get'>");
 	cgit_add_hidden_formfields(1, 0, "stats");
-	html("<table><tr><td colspan='2'/></tr>");
+	html("<table><tr><td colspan='2'></tr>");
 	if (ctx.repo->max_stats > 1) {
 		html("<tr><td class='label'>Period:</td>");
 		html("<td class='ctrl'><select name='period' onchange='this.form.submit();'>");
@@ -408,7 +408,7 @@ void cgit_show_stats(void)
 	html_intoption(100, "100", top);
 	html_intoption(-1, "all", top);
 	html("</select></td></tr>");
-	html("<tr><td/><td class='ctrl'>");
+	html("<tr><td><td class='ctrl'>");
 	html("<noscript><input type='submit' value='Reload'/></noscript>");
 	html("</td></tr></table>");
 	html("</form>");
diff --git a/ui-tree.c b/ui-tree.c
index 08a8505..f8cbf7a 100644
--- a/ui-tree.c
+++ b/ui-tree.c
@@ -269,7 +269,7 @@ static void ls_head(void)
 	html("<th class='left'>Mode</th>");
 	html("<th class='left'>Name</th>");
 	html("<th class='right'>Size</th>");
-	html("<th/>");
+	html("<th>");
 	html("</tr>\n");
 }
 
-- 
2.20.1



  parent reply	other threads:[~2019-02-18 20:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18 20:46 [PATCH 0/5] SVG diffstat graphs and HTML5 aklhfex
2019-02-18 20:46 ` [PATCH 1/5] ui-diff: use SVG for diffstat graphs aklhfex
2019-02-18 20:46 ` [PATCH 2/5] Replace table summary attribute with aria-label aklhfex
2019-02-18 20:46 ` aklhfex [this message]
2019-02-18 20:46 ` [PATCH 4/5] ui-log,ui-refs: ensure there are cells for each column aklhfex
     [not found]   ` <CAGFiPxeyoWYT44SUOo-isKeErvYu-c4J78HtWnwse3ueKQV0fA@mail.gmail.com>
     [not found]     ` <CAGFiPxfmGgy0OVCnxNs6aY5RG9XNQGohOerv2Xu0GhV2KHpG5g@mail.gmail.com>
2019-02-18 21:15       ` [PATCH 4/5] ui-log, ui-refs: " 1melissadenee
2019-02-18 20:46 ` [PATCH 5/5] ui-shared: add encoding declaration aklhfex

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190218204644.440-4-aklhfex@gmail.com \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).