List for cgit developers and users
 help / color / Atom feed
* [RFC] remove "diff" link at top bar?
@ 2019-04-03  1:14 e
  0 siblings, 0 replies; only message in thread
From: e @ 2019-04-03  1:14 UTC (permalink / raw)


I've been running this for a few months, now, but forgot to send
it out for review.  Perhaps I'm missing something obvious, but
I've never understood the purpose exposing the "diff" endpoint
at the top navigation bar...

The following applies on top of my:
"ui-shared: improve pageheader display on text-based browsers"
patch which hasn't gotten any feedback, yet.

-----------8<----------------
Subject: [PATCH] ui-shared: get rid of "diff" link at top bar

It's pointless clutter, since the "commit" link shows
the same information.
---
 ui-shared.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/ui-shared.c b/ui-shared.c
index a859ab0..1bb22e6 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -1054,9 +1054,6 @@ void cgit_print_pageheader(void)
 		html(" ");
 		cgit_commit_link("commit", NULL, hc("commit"),
 				 ctx.qry.head, ctx.qry.sha1, ctx.qry.vpath);
-		html(" ");
-		cgit_diff_link("diff", NULL, hc("diff"), ctx.qry.head,
-			       ctx.qry.sha1, ctx.qry.sha2, ctx.qry.vpath);
 		if (ctx.repo->max_stats) {
 			html(" ");
 			cgit_stats_link("stats", NULL, hc("stats"),
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-03  1:14 [RFC] remove "diff" link at top bar? e

List for cgit developers and users

Archives are clonable: git clone --mirror http://inbox.vuxu.org/cgit

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.cgit


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git