List for cgit developers and users
 help / color / mirror / Atom feed
* [PATCH 1/2] ui-blame: bail if blob is binary
@ 2019-12-18 21:52 june
  2019-12-18 21:52 ` [PATCH 2/2] ui-tree: don't link to blame for binary blobs june
  0 siblings, 1 reply; 2+ messages in thread
From: june @ 2019-12-18 21:52 UTC (permalink / raw)


This avoids piping binary blobs through the source-filter.
---
 ui-blame.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ui-blame.c b/ui-blame.c
index 644c30a..ecbe325 100644
--- a/ui-blame.c
+++ b/ui-blame.c
@@ -151,6 +151,10 @@ static void print_object(const struct object_id *oid, const char *path,
 	cgit_tree_link("tree", NULL, NULL, ctx.qry.head, rev, path);
 	html(")\n");
 
+	if (buffer_is_binary(buf, size)) {
+		html("<div class='error'>blob is binary.</div>");
+		goto cleanup;
+	}
 	if (ctx.cfg.max_blob_size && size / 1024 > ctx.cfg.max_blob_size) {
 		htmlf("<div class='error'>blob size (%ldKB)"
 		      " exceeds display size limit (%dKB).</div>",
-- 
2.23.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-18 21:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 21:52 [PATCH 1/2] ui-blame: bail if blob is binary june
2019-12-18 21:52 ` [PATCH 2/2] ui-tree: don't link to blame for binary blobs june

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).